Conversation
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
==========================================
- Coverage 76.60% 75.94% -0.66%
==========================================
Files 27 25 -2
Lines 1650 1501 -149
==========================================
- Hits 1264 1140 -124
+ Misses 386 361 -25
|
Collaborator
Author
|
@ChrisJefferson - is this what you had in mind? |
Collaborator
Author
|
Using the variable v caused gapdev/tst/teststandard/varnames.tst to fail |
Collaborator
Author
|
Unfortunately two separate changes made in the one commit. |
Collaborator
Author
|
This is the PR where the `NC versions of PreImages... functions were added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recently added Download function is expected to move to the main GAP library once it has been used by other packages and any problems ironed out. This PR prevents the Download function being read/used once GAP version 4.13.0 is released, on the assumption that the transfer has been made by then.