fix PrimitiveElement vs. PrimitiveRoot#74
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #74 +/- ##
==========================================
- Coverage 77.89% 77.87% -0.02%
==========================================
Files 29 29
Lines 1823 1826 +3
==========================================
+ Hits 1420 1422 +2
- Misses 403 404 +1
🚀 New features to boost your workflow:
|
Collaborator
|
Thanks @ThomasBreuer - I was starting to work on this earlier this morning but had no way of checking that PrimitiveElement was still correct the correct term in Magma. I'm intending to move the test for ConvertToMagmaInputString from others.tst to a new magma.tst before releasing a new version. |
Collaborator
|
Realised there is no need for a new magma.tst - made some small adjustments to the manual and released v0.88. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In GAP,
PrimitiveElement(F)denotes an element that generatesFoverLeftActingDomain(F), whereasPrimitiveRoot(F)is a generator of the multiplicative group ofFifFis a finite field.In Magma, according to its documentation,
PrimitiveElement(F)for a finite fieldFis always a primitive root.(Currently the way how finite fields are constructed in GAP seems to guarantee that
PrimitiveElement(F)always is a primitive root, like in Magma. Thus there was no problem in practice.)