Skip to content

correcting behaviour of LeftCoset creation#78

Merged
cdwensley merged 1 commit intogap-packages:masterfrom
rlutowsk:rl-leftcosets
Apr 10, 2025
Merged

correcting behaviour of LeftCoset creation#78
cdwensley merged 1 commit intogap-packages:masterfrom
rlutowsk:rl-leftcosets

Conversation

@rlutowsk
Copy link
Copy Markdown
Contributor

@rlutowsk rlutowsk commented Apr 9, 2025

Resolves #77.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.96%. Comparing base (6ce1627) to head (3cd7900).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #78   +/-   ##
=======================================
  Coverage   77.96%   77.96%           
=======================================
  Files          29       29           
  Lines        1829     1829           
=======================================
  Hits         1426     1426           
  Misses        403      403           
Files with missing lines Coverage Δ
lib/lcset.gi 92.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fingolfin
Copy link
Copy Markdown
Member

@cdwensley do you by chance have time to get this into another release? I am considering releasing GAP 4.14.1 on Friday and it'd be nice to have this in :-)

@fingolfin
Copy link
Copy Markdown
Member

Uhh, by the way, the latest version of utils in the GAP distro is 0.85 -- as that is the latest version on the website, https://gap-packages.github.io/utils/. So we never picked up 0.86, 0.87, 0.88 -- did something go wrong with the release script?

@cdwensley cdwensley merged commit 7cbdb84 into gap-packages:master Apr 10, 2025
6 checks passed
@cdwensley
Copy link
Copy Markdown
Collaborator

@fingolfin Yes, will release 0.89 later today.
It's not just utils missing its latest version, the same is true of xmodalg: 1.28 released 31/1/25 but still 1.23 on the website.
It appears that my ReleaseTools clone is up-to-date: release-gap-package is dated 16 May 2024.

@fingolfin
Copy link
Copy Markdown
Member

But for some reasons your gh-pages branches are not being updated.

Do you have a gh-pages directory in your package clones? Is it up-to-date? Perhaps you can cd gh-pages && git push and see if it works? and if it does, git log and report the output

@cdwensley
Copy link
Copy Markdown
Collaborator

Had to do a git pull first, but then the push appeared to work.
Realise now that I have been forgetting the instruction "To complete your release, run 'git push' in your gh-pages directory'.
Certainly did not do that with 0.88 but will try to remember later today.
Here is the git log:
''christopherwensley@Christophers-iMac gh-pages % git log
commit 4ad1cde (HEAD -> gh-pages, utils-origin/gh-pages, origin/gh-pages)
Author: Max Horn max@quendi.de
Date: Wed Feb 21 00:47:20 2024 +0100

Update to latest GitHubPagesForGAP template

commit 544cd04
Author: cdwensley cdwensley.maths@btinternet.com
Date: Tue Jan 23 18:39:12 2024 +0000

Update website for utils 0.85

''

@cdwensley
Copy link
Copy Markdown
Collaborator

Attempted to release a new version of xmodalg and then push to gh-pages, but that failed, so raised an issue there.

@cdwensley
Copy link
Copy Markdown
Collaborator

@fingolfin: Success - version 0.89 released, and https://gap-packages.github.io/utils/ was updated automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

strange behaviour of LeftCosets

3 participants