Implement MultVectorRight for lists#6280
Merged
ThomasBreuer merged 1 commit intomasterfrom Mar 25, 2026
Merged
Conversation
fingolfin
changed the title
MultVectorRight for lists
fingolfin
added
kind: enhancement
ThomasBreuer
requested changes
Mar 24, 2026
lib/listcoef.gd
Outdated
| ## This operation calculates <A>mul</A>*<A>list1</A> in-place. | ||
| ## These operations multiply the entries of <A>list1</A> by <A>mul</A> in-place. | ||
| ## The operation <Ref Oper="MultVectorLeft"/> calculates <A>mul \cdot list1</A> and | ||
| ## the operation <Ref Oper="MultVectorRight"/> calculates <A>list1 \cdot mul</A>. |
Contributor
There was a problem hiding this comment.
This is not allowed GAPDoc syntax for <A> elements.
And the description is not correct: If both mul and list1 are lists of nesting depth 1 then mul * list1 and list1 * mul sum up the pointwise products, due to the rules of list arithmetics, but the MultVector functions compute the list of products of the elements of list1 with mul.
(And we could rename list1 to list.)
Member
Author
There was a problem hiding this comment.
Ouch, indeed, I totally missed that the AI produced nonsense here (not an excuse, the blame is on me).
I've pushed an improved version.
AI assistance: Codex prepared the test updates. Co-authored-by: Pavol Kollár <palkollar9@gmail.com> Co-authored-by: Max Horn <max@quendi.de> Co-authored-by: Codex <codex@openai.com>
fingolfin
force-pushed
the
mh/MultVectorRight
branch
from
b362f43 to
49a2283
Compare
ThomasBreuer
approved these changes
Mar 25, 2026
Contributor
ThomasBreuer
left a comment
ThomasBreuer
left a comment
There was a problem hiding this comment.
Thanks, looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI assistance: Codex prepared the test updates.
Co-authored-by: Pavol Kollár palkollar9@gmail.com
Co-authored-by: Max Horn max@quendi.de
Co-authored-by: Codex codex@openai.com
Extracted from PR #5980