Skip to content

PlainListCopy for list not knowing they are small#6333

Merged
fingolfin merged 1 commit intomasterfrom
mh/PlainListCopy
Apr 21, 2026
Merged

PlainListCopy for list not knowing they are small#6333
fingolfin merged 1 commit intomasterfrom
mh/PlainListCopy

Conversation

@fingolfin
Copy link
Copy Markdown
Member

@fingolfin fingolfin commented Apr 19, 2026 •
edited
Loading

Fix PlainListCopy for lists which are small but do not know it yet know they are in filter IsSmallList; this is e.g. needed for the semigroups test suite.

This is a regression caused by PR #6327

@fingolfin fingolfin added topic: kernel release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes labels Apr 19, 2026
@fingolfin
Copy link
Copy Markdown
Member Author

fingolfin commented Apr 20, 2026

@james-d-mitchell @ChrisJefferson we kinda need this to unbreak the semigroups test suite

@james-d-mitchell
Copy link
Copy Markdown
Contributor

james-d-mitchell commented Apr 20, 2026

@james-d-mitchell @ChrisJefferson we kinda need this to unbreak the semigroups test suite

Will look tomorrow morning. Have I missed something how is the Semigroups test suite broken?

@fingolfin
Copy link
Copy Markdown
Member Author

fingolfin commented Apr 20, 2026

It is broken in the package distro, see the status badge at https://github.com/gap-system/PackageDistro and the daily report linked there

@fingolfin fingolfin added the regression A bug that only occurs in the branch, not in a release label Apr 20, 2026
@fingolfin
Copy link
Copy Markdown
Member Author

fingolfin commented Apr 20, 2026

Ah, and sorry, I just noticed that I didn't put into the description that this is a recent regression due to PR #6327

@ChrisJefferson
Copy link
Copy Markdown
Contributor

ChrisJefferson commented Apr 21, 2026

Looks good to me!

james-d-mitchell
james-d-mitchell approved these changes Apr 21, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@james-d-mitchell james-d-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also looks good to me. I'm not sure why the previous behaviour was causing Semigroups tests to fail (we aren't apparently using AsPlist or CopyPlainList directly), but this seems like a sensible change regardless.

@fingolfin
Copy link
Copy Markdown
Member Author

fingolfin commented Apr 21, 2026

Well, AsSet and various other functions use these helpers in various methods, which is how this affected Semigroups (and in the end, also other code, but it was the semigroups tests which luckily revealed this!)

@fingolfin fingolfin merged commit 22d51cc into master Apr 21, 2026
32 checks passed
@fingolfin fingolfin deleted the mh/PlainListCopy branch April 21, 2026 22:12
cdwensley pushed a commit that referenced this pull request Apr 22, 2026
@fingolfin @cdwensley
PlainListCopy for list not knowing they are small (#6333)
f2e4806
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrisJefferson ChrisJefferson ChrisJefferson approved these changes

@james-d-mitchell james-d-mitchell james-d-mitchell approved these changes

Assignees

No one assigned

Labels

regression A bug that only occurs in the branch, not in a release release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: kernel

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fingolfin @james-d-mitchell @ChrisJefferson