Skip to content

Uprank {Copy,Extract}SubMatrix methods for compressed matrices#6349

Merged
fingolfin merged 1 commit intomasterfrom
mh/fix-ExtractSubMatrix
Apr 29, 2026
Merged

Uprank {Copy,Extract}SubMatrix methods for compressed matrices#6349
fingolfin merged 1 commit intomasterfrom
mh/fix-ExtractSubMatrix

Conversation

@fingolfin
Copy link
Copy Markdown
Member

... so that they are actually used.

Also remove redundant CopySubVector methods.

... so that they are actually used.

Also remove redundant `CopySubVector` methods.
@fingolfin fingolfin requested a review from ThomasBreuer April 28, 2026 16:14
@fingolfin fingolfin added regression A bug that only occurs in the branch, not in a release release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes labels Apr 28, 2026
@fingolfin fingolfin changed the title Uprank {Copy,Extract}SubMatrix for compressed matrices Uprank {Copy,Extract}SubMatrix methods for compressed matrices Apr 28, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.63%. Comparing base (5fbcf41) to head (1e3f9a6).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6349   +/-   ##
=======================================
  Coverage   78.62%   78.63%           
=======================================
  Files         684      684           
  Lines      292701   292689   -12     
  Branches     8686     8660   -26     
=======================================
+ Hits       230148   230149    +1     
+ Misses      60744    60729   -15     
- Partials     1809     1811    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the new generic methods that were introduced in #6329 have a higher rank than the old special methods.

Eventually we should perhaps define Is8BitMatrixRep to imply IsMatrix, such that the installations for the different kinds of matrix objects will be more comparable,
but in another pull request.

(According to the documentation of NewRepresentation, such implications are not intended, but they are used for example for IsPlistMatrixRep which implies IsMatrixObj. Thus perhaps the formulations in the documentation of NewRepresentation should be changed.)

@fingolfin fingolfin merged commit c4b3c16 into master Apr 29, 2026
33 checks passed
@fingolfin fingolfin deleted the mh/fix-ExtractSubMatrix branch April 29, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

regression A bug that only occurs in the branch, not in a release release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants