Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6354 +/- ##
==========================================
- Coverage 76.11% 74.51% -1.60%
==========================================
Files 683 676 -7
Lines 292488 288377 -4111
Branches 8644 8268 -376
==========================================
- Hits 222631 214898 -7733
- Misses 68033 71693 +3660
+ Partials 1824 1786 -38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Based on experiments, just testing the order seemed to be fastest. Though of course it also depends on the representation used for the group.
- provide a better `TransitiveGroupsAvailable` fallback - remove a bunch of SmallGroup and IdGroup uses - remove tst/testbugfix/2005-05-03-t00070.tst (an equivalent test was added to the smallgrp package recently) - modify some .tst file to run parts only if certain packages are available, via `#@if IsPackageMarkedForLoading(...)` - don't load `ctbllib` (and all its dependencies) in `ctblmaps.tst`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TransitiveGroupsAvailablefallback#@if IsPackageMarkedForLoading(...)ctbllib(and all its dependencies) inctblmaps.tstTogether with #6353 this is meant to resolve issue #6346, once it is done, which is not.
TODO:
testinstallwith--bare#@if IsPackageMarkedForLoading(...)guards etc)