Skip to content

Improve documentation of OnTuplesSets, OnSetsDisjointSets, OnSetsTuples#6370

Merged
fingolfin merged 3 commits intogap-system:masterfrom
lhsoicher:lhs/OnXY
May 8, 2026
Merged

Improve documentation of OnTuplesSets, OnSetsDisjointSets, OnSetsTuples#6370
fingolfin merged 3 commits intogap-system:masterfrom
lhsoicher:lhs/OnXY

Conversation

@lhsoicher
Copy link
Copy Markdown
Contributor

No description provided.

@fingolfin fingolfin added the topic: documentation Issues and PRs related to documentation label May 6, 2026
OnTuplesSets, OnTuplesTuples, OnSetsTuples, OnSetsSets, and OnSetsDisjointSets.
Copy link
Copy Markdown
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I like it!

To make gaplint happy, we need the three trailing spaces indicate by my code change requests. Sorry about that. But the good news is: I can also do that by just applying the code change suggestions here if you have nothing else you'd like to change.

Comment thread lib/oprt.gd Outdated
Comment thread lib/oprt.gd Outdated
Comment thread lib/oprt.gd Outdated
@fingolfin fingolfin added the release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes label May 7, 2026
@fingolfin fingolfin changed the title Improve documentation of OnTuplesSets Improve documentation of OnTuplesSets, OnSetsDisjointSets, OnSetsTuples May 7, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.69%. Comparing base (aa52ee2) to head (f13fa98).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6370   +/-   ##
=======================================
  Coverage   78.69%   78.69%           
=======================================
  Files         684      684           
  Lines      292892   292892           
  Branches     8660     8660           
=======================================
  Hits       230488   230488           
  Misses      60590    60590           
  Partials     1814     1814           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: Max Horn <max@quendi.de>
@lhsoicher lhsoicher marked this pull request as ready for review May 8, 2026 10:20
@fingolfin fingolfin enabled auto-merge (squash) May 8, 2026 10:32
@fingolfin fingolfin merged commit 161a3ca into gap-system:master May 8, 2026
26 of 30 checks passed
cdwensley pushed a commit that referenced this pull request May 8, 2026
 Improve the documentation for the action functions
- OnTuplesSets
- OnTuplesTuples,
- OnSetsTuples,
- OnSetsSets,
- OnSetsDisjointSets.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: documentation Issues and PRs related to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants