Ensure more tests pass with gap --bare#6387
Conversation
- remove a bunch of SmallGroup and IdGroup uses - remove tst/testbugfix/2005-05-03-t00070.tst (an equivalent test was added to the smallgrp package recently) - modify some .tst file to run parts only if certain packages are available, via `#@if IsPackageMarkedForLoading(...)` - don't load `ctbllib` (and all its dependencies) in `ctblmaps.tst`
fingolfin
added
topic: tests
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6387 +/- ##
==========================================
- Coverage 78.69% 78.68% -0.02%
==========================================
Files 684 683 -1
Lines 292902 292902
Branches 8665 8658 -7
==========================================
- Hits 230508 230462 -46
- Misses 60575 60621 +46
Partials 1819 1819 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ThomasBreuer
left a comment
ThomasBreuer
left a comment
There was a problem hiding this comment.
Looks good, just a few comments.
So the message is:
In test files for the GAP library,
- do not call
LoadPackage, - if it is necessary to call functions from a package in a test then surround this test with comment lines
#@if IsPackageMarkedForLoading( ... )and#@fimentioning the package in question.
| # MTX.HomogeneousComponents | ||
| # | ||
| gap> G:=SmallGroup(24, 3);; | ||
| gap> G:=SL(2, 3);; |
There was a problem hiding this comment.
Here a pc group gets replaced by a matrix group.
I think this is not a problem for the test.
| gap> SortedList(List(SubdirectProducts(G, G), StructureDescription)); | ||
| [ "(C3 x C3) : C2", "S3", "S3 x S3" ] | ||
| gap> SortedList(List(SubdirectProducts(H, H), Size)); | ||
| [ 24, 96, 288, 576 ] |
There was a problem hiding this comment.
This one is a bit unfortunate, but StructureDescription isn't quite stable on some of these groups. Anyway, I don't think we loose much by this change; it's unlikely a bug would keep all the other structures right, and the sizes here, but mess up the isomorphism type of one of the outputs in this one example somehow. Not impossible of course; but then one could say the same even with this test was as it was before.
There was a problem hiding this comment.
Perhaps a comment in the test file that explains the situation would be useful.
(In a few experiments, I did not see an instability in the StructureDescription output.)
There was a problem hiding this comment.
I'll add a comment. It seems to depend on which packages are present: with my "default" GAP, I see
gap> H := SymmetricGroup(4);;
gap> SortedList(List(SubdirectProducts(H, H), StructureDescription));
[ "((C2 x C2 x C2 x C2) : C3) : C2", "(A4 x A4) : C2", "S4", "S4 x S4" ]
When I use gap -A, I get
gap> H := SymmetricGroup(4);;
gap>SortedList(List(SubdirectProducts(H, H), StructureDescription));
[ "(C2 x C2) : ((C3 x A4) : C2)", "(C2 x C2) : S4", "S4", "S4 x S4" ]
There was a problem hiding this comment.
Ah, this kind of instability is meant, dependence on loaded packages.
Thanks for the comments.
- remove a bunch of SmallGroup and IdGroup uses in tst files - remove tst/testbugfix/2005-05-03-t00070.tst (an equivalent test was added to the smallgrp package recently) - modify some .tst file to run parts only if certain packages are available, via `#@if IsPackageMarkedForLoading(...)` - don't load `ctbllib` (and all its dependencies) in `ctblmaps.tst`
- remove a bunch of SmallGroup and IdGroup uses in tst files - remove tst/testbugfix/2005-05-03-t00070.tst (an equivalent test was added to the smallgrp package recently) - modify some .tst file to run parts only if certain packages are available, via `#@if IsPackageMarkedForLoading(...)` - don't load `ctbllib` (and all its dependencies) in `ctblmaps.tst`
2 participants
#@if IsPackageMarkedForLoading(...)ctbllib(and all its dependencies) inctblmaps.tstExtracted from PR #6346