189 refactor new code imported from gl workflow scripts #232
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #232 +/- ##
=======================================
Coverage 90.24% 90.24%
=======================================
Files 42 42
Lines 2009 2009
=======================================
Hits 1813 1813
Misses 196 196 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| s3_artifacts = S3Artifacts(s3_bucket_name) | ||
|
|
||
| commitish_short = commitish[:8] |
There was a problem hiding this comment.
The gardenlinux.features.CName class is capable of calculating the correct short commit hash based on the Git commit hash and defined behavior. Please do not truncate commit hashes elsewhere in the code.
There was a problem hiding this comment.
This particular short commit variable is used to construct an s3 objects filter. Not sure how CName instance could help there.
There was a problem hiding this comment.
Otherwise replaced its use for CName call below with full commit id.
There was a problem hiding this comment.
Use commitish_short = cname.commit_id for that purpose or directly Prefix=f"meta/singles/{cname}-{version}-{cname.commit_id}".
There was a problem hiding this comment.
You may also use Prefix=f"meta/singles/{cname.cname} if applicable.
There was a problem hiding this comment.
Switched to using cname.cname where appropriate. cname.commit_id however doesn't work as expected and breaks tests. Will check it out in a separate PR.
vivus-ignis
deleted the
189-refactor-new-code-imported-from-gl-workflow-scripts
branch
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #189
This PR also includes a fixed release notes mockup file.