Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #294 +/- ##
==========================================
- Coverage 91.51% 91.41% -0.11%
==========================================
Files 42 49 +7
Lines 2158 2585 +427
==========================================
+ Hits 1975 2363 +388
- Misses 183 222 +39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for your detailed feedback. I have heavily restricted the formatter and implemented all your comments. It's still a massive PR, as it also contains the difference generator now. So take your time! I was not able to find a python package or better way to unpack .oci containers, so I've implemented unpacking logic myself. It works so far. |
NotTheEvilOne
left a comment
There was a problem hiding this comment.
In general this is a nice feature. I'm not sure if gl-diff is the most suitable command line tool name for it. As you compare OCI images or tar files based on features you may want to name it something similar to gl-feature-fs-diff?
|
Thanks for your valuable feedback, I tried to clean things up as much as possible |
NotTheEvilOne
left a comment
There was a problem hiding this comment.
One note left, otherwise looks good. Great work.
| nightly_a, nightly_b = ( | ||
| Nightly(*n.split(",")) for n in f.read().rstrip().split("\n") | ||
| ) | ||
| if nightly_a.run_number != "": |
There was a problem hiding this comment.
Here you can also use a template for at least part of the generated content.
There was a problem hiding this comment.
I've extended the template scope to also include the run number
What this PR does / why we need it:
workflowsdirectory, to use features of the library and to be able to test the output with simple unit tests