Skip to content

Change modifiers S3 artifact metadata to be a list of features#312

Merged
NotTheEvilOne merged 1 commit intomainfrom
fix/s3-metadata-modifiers-as-list
Feb 10, 2026
Merged

Change modifiers S3 artifact metadata to be a list of features#312
NotTheEvilOne merged 1 commit intomainfrom
fix/s3-metadata-modifiers-as-list

Conversation

@NotTheEvilOne
Copy link
Contributor

What this PR does / why we need it:
This PR fixes an regression in the generated S3 artifact metadata. modifiers should be a list of strings but was formatted as a ,-separated string instead.

@NotTheEvilOne NotTheEvilOne self-assigned this Feb 10, 2026
@NotTheEvilOne NotTheEvilOne added the bug Something isn't working label Feb 10, 2026
@NotTheEvilOne NotTheEvilOne added this to the 2026-02 milestone Feb 10, 2026
@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.65%. Comparing base (ab55b23) to head (febc8c9).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/gardenlinux/features/cname.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #312      +/-   ##
==========================================
- Coverage   91.68%   91.65%   -0.03%     
==========================================
  Files          42       42              
  Lines        2129     2134       +5     
==========================================
+ Hits         1952     1956       +4     
- Misses        177      178       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
On-behalf-of: SAP <tobias.wolf@sap.com>
@NotTheEvilOne NotTheEvilOne force-pushed the fix/s3-metadata-modifiers-as-list branch from 94dd78e to febc8c9 Compare February 10, 2026 08:44
Copy link

@saubhikdattagithub saubhikdattagithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as discussed

@NotTheEvilOne NotTheEvilOne merged commit 1294c05 into main Feb 10, 2026
14 of 16 checks passed
@NotTheEvilOne NotTheEvilOne deleted the fix/s3-metadata-modifiers-as-list branch February 10, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants