7 enable automated publishing to gh pages#8
Conversation
…running corepack enable in your terminal.
|
@yeoldegrove @fwilhe , could one of you please review and approve? Workflow runs now up to the point it fails as desired, because of branch protection (see https://github.com/gardenlinux/website/actions/runs/17759892815)? |
yeoldegrove
left a comment
yeoldegrove
left a comment
There was a problem hiding this comment.
- Having commits pinned down for actions is a best practice we follow in our other repos.
- Could we rename the branch to
main?
| # using the `master` branch as the default branch. | ||
| push: | ||
| branches: [main] | ||
| branches: [master] |
There was a problem hiding this comment.
Could we rename this to main like it is the default for newly created repos?
We can also merge this already with main and simply rename the branch directly after that.
| steps: | ||
| # Check out the branch | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 |
There was a problem hiding this comment.
please pin 08c6903cd8c0fde910a37f88322edcfb5dd907a8
| run: corepack enable | ||
| # Setup Node.js with yarn support | ||
| - name: Setup Node | ||
| uses: actions/setup-node@v4 |
There was a problem hiding this comment.
please pin a0853c24544627f65ddf259abe73b1d18a591444
| cache: yarn # npm / pnpm / yarn | ||
| # Configure GitHub Pages | ||
| - name: Setup Pages | ||
| uses: actions/configure-pages@v5 |
There was a problem hiding this comment.
please pin 983d7736d9b0ae728b81ab479565c72886d7745b
| # Upload the artefact to GitHub Pages | ||
| - name: Upload artifact | ||
| uses: actions/upload-pages-artifact@v3 | ||
| uses: actions/upload-pages-artifact@v4 |
There was a problem hiding this comment.
please use 7b1f4a764d45c48632c6b24a0339c27f5614fb0b instead of v4 to pin to commits
| # Deployment job | ||
| deploy: | ||
| # Execute deployment only from master branch | ||
| if: github.ref == 'refs/heads/master' |
Thanks! Done with dc9274c and tested with https://github.com/gardenlinux/website/actions/runs/17761718308 Can you please review? |
2 participants
What this PR does / why we need it:
Fixes errors related to node.js, yarn and file paths in the publishing workflow.
Which issue(s) this PR fixes:
Fixes #7
Special notes for your reviewer:
Release note: