Added only video h265 with new imp#7
Conversation
garethsb
left a comment
garethsb
left a comment
There was a problem hiding this comment.
A few little things I missed before
Co-authored-by: Gareth Sylvester-Bradley <31761158+garethsb@users.noreply.github.com>
Co-authored-by: Gareth Sylvester-Bradley <31761158+garethsb@users.noreply.github.com>
Co-authored-by: Gareth Sylvester-Bradley <31761158+garethsb@users.noreply.github.com>
…-cpp into only-video-h265
|
Hi @diegonunes4, I've moved the helper functions I think will be generally useful out of source file nmos/sdp_utils.cpp and into header nmos/sdp_utils.h in a commit, 45e12f5, on my PR branch. In a second commit, 2dfb3d3, I implemented the changes I proposed to the IS-04 resource factory functions to just simplify the resource creation in nmos-cpp-node/node_implementation.cpp slightly. If you wanted to rebase your H.265 branch on https://github.com/garethsb/nmos-cpp/tree/video-h264, you could start using these (and it would also fix the Ubuntu 14.04 build). |
…the sdp parameters
|
@diegonunes4 Bumped to update to nmos-cpp/cci.20220428 (had to do several commits via web as GitHub gave me |
|
What's needed next is an example usage like the https://github.com/garethsb/nmos-cpp/pull/8/files#diff-5c117d7d1fdbccc35cf5241c53933672970ecd6606d8f0375c92e3b5e2df5f8d for H.264. |
|
Hopefully now compiling against nmos-cpp/cci.20220428. Other task is to switch from the integer parameters to string ones, as proposed here: AMWA-TV/bcp-006#3 (comment) |
|
Hi @diegonunes4, @pedro-alves-ferreira, I squashed and rebased these changes on current HEAD of sony/nmos-cpp master and pushed to https://github.com/garethsb/nmos-cpp/tree/video-h265 as I didn't have permission to force push to Diego's PR branch (still getting I'm about to prepare a separate branch for video/jxsv based on BCP-006-01. |
* Add bulkPropertiesManager control class * Add fixed role to bulkPropertiesManger * Add fixed role and correct method_id in bulkPropertiesManager * add Device Configuration method handlers * Device Configuration method handlers in NcBulkPropertiesManager method * Add bulkProperties endpoints * Typedefs for bulk properties manager user defined methods * Schema validation on bulkProperties endpoint * Pass control protocol resources required for backup/restore --------- Co-authored-by: Simon Lo <simon.lo@sony.com>
2 participants
@garethsb I used the separated files approach as you suggested, I think it looks better this way.
Also do you want me to add the rest of the parameters or this ones are ok?
Based on our analysis at AMWA-TV/bcp-006#3.