Remove all code referencing old tab navigation

Summary:
  - Add getHelpURI() to PhabricatorApplication for application user guides.
  - Add a new "help" icon menu item and skeletal Diviner application.
  - Move help tabs to Applications where they exist, document the other ones that don't exist yet.
  - Grep for all tab-related stuff and delete it.

Test Plan: Clicked "help" for some apps. Clicked around randomly in a bunch of other apps.

Reviewers: btrahan, vrana

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D3267

Author: epriestley

src/__phutil_library_map__.php

@@ -549,6 +549,7 @@
     'PhabricatorApplicationDaemons' => 'applications/daemon/application/PhabricatorApplicationDaemons.php',
     'PhabricatorApplicationDifferential' => 'applications/differential/application/PhabricatorApplicationDifferential.php',
     'PhabricatorApplicationDiffusion' => 'applications/diffusion/application/PhabricatorApplicationDiffusion.php',
+    'PhabricatorApplicationDiviner' => 'applications/diviner/application/PhabricatorApplicationDiviner.php',
     'PhabricatorApplicationFact' => 'applications/fact/application/PhabricatorApplicationFact.php',
     'PhabricatorApplicationFlags' => 'applications/flag/application/PhabricatorApplicationFlags.php',
     'PhabricatorApplicationLaunchView' => 'applications/meta/view/PhabricatorApplicationLaunchView.php',
@@ -1671,6 +1672,7 @@
     'PhabricatorApplicationDaemons' => 'PhabricatorApplication',
     'PhabricatorApplicationDifferential' => 'PhabricatorApplication',
     'PhabricatorApplicationDiffusion' => 'PhabricatorApplication',
+    'PhabricatorApplicationDiviner' => 'PhabricatorApplication',
     'PhabricatorApplicationFact' => 'PhabricatorApplication',
     'PhabricatorApplicationFlags' => 'PhabricatorApplication',
     'PhabricatorApplicationLaunchView' => 'AphrontView',

src/applications/base/PhabricatorApplication.php

@@ -70,6 +70,21 @@ public function getTitleGlyph() {
     return null;
   }
 
+  public function getHelpURI() {
+    // TODO: When these applications get created, link to their docs:
+    //
+    //  - Conduit
+    //  - Drydock
+    //  - Herald
+    //  - OAuth Server
+    //  - Owners
+    //  - Phame
+    //  - Slowvote
+
+
+    return null;
+  }
+
 
 /* -(  URI Routing  )-------------------------------------------------------- */
 

src/applications/calendar/controller/PhabricatorCalendarController.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -30,12 +30,6 @@ public function buildStandardPageResponse($view, array $data) {
     // use "keyboard" since it looks vaguely similar.
     $page->setGlyph("\xE2\x8C\xA8");
 
-    $page->appendChild($view);
-    $page->setTabs(
-      array(
-      ),
-      idx($data, 'tab'));
-
     $response = new AphrontWebpageResponse();
     return $response->setContent($page->render());
   }

src/applications/conduit/controller/PhabricatorConduitController.php

@@ -25,21 +25,12 @@ abstract class PhabricatorConduitController extends PhabricatorController {
   protected $showSideNav;
 
   public function buildStandardPageResponse($view, array $data) {
-    $doclink = PhabricatorEnv::getDoclink(
-      'article/Conduit_Technical_Documentation.html'
-      );
-
     $page = $this->buildStandardPageView();
 
     $page->setApplicationName('Conduit');
     $page->setBaseURI('/conduit/');
     $page->setTitle(idx($data, 'title'));
     $page->setGlyph("\xE2\x87\xB5");
-    $page->setTabs(array(
-      'help' => array(
-        'href' => $doclink,
-        'name' => 'Help')
-      ), null);
 
     if ($this->showSideNav()) {
 

src/applications/daemon/controller/PhabricatorDaemonTimelineConsoleController.php

@@ -65,7 +65,6 @@ public function processRequest() {
       $nav,
       array(
         'title' => 'Timeline',
-        'tab'   => 'timeline',
       ));
   }
 

src/applications/differential/controller/DifferentialController.php

@@ -34,7 +34,6 @@ public function buildStandardPageResponse($view, array $data) {
     $page->setTitle(idx($data, 'title'));
     $page->setGlyph("\xE2\x9A\x99");
     $page->appendChild($view);
-    $page->setIsLoggedOut($viewer_is_anonymous);
     $page->setSearchDefaultScope(PhabricatorSearchScope::SCOPE_OPEN_REVISIONS);
 
     $response = new AphrontWebpageResponse();

src/applications/differential/controller/DifferentialDiffCreateController.php

@@ -84,7 +84,6 @@ public function processRequest() {
       $panel,
       array(
         'title' => 'Create Diff',
-        'tab' => 'create',
       ));
   }
 

src/applications/differential/controller/DifferentialRevisionListController.php

@@ -228,7 +228,6 @@ public function processRequest() {
       $side_nav,
       array(
         'title' => 'Differential Home',
-        'tab' => 'revisions',
       ));
   }
 

src/applications/diffusion/application/PhabricatorApplicationDiffusion.php

@@ -30,6 +30,10 @@ public function getIconURI() {
     return celerity_get_resource_uri('/rsrc/image/app/app_diffusion.png');
   }
 
+  public function getHelpURI() {
+    return PhabricatorEnv::getDoclink('article/Diffusion_User_Guide.html');
+  }
+
   public function getRoutes() {
     return array(
       '/r(?P<callsign>[A-Z]+)(?P<commit>[a-z0-9]+)'

src/applications/diffusion/controller/DiffusionController.php

@@ -47,15 +47,6 @@ public function buildStandardPageResponse($view, array $data) {
     $page->setBaseURI('/diffusion/');
     $page->setTitle(idx($data, 'title'));
     $page->setGlyph("\xE2\x89\x88");
-    $page->setTabs(
-      array(
-        'help' => array(
-          'href' => PhabricatorEnv::getDoclink(
-            'article/Diffusion_User_Guide.html'),
-          'name' => 'Help',
-        ),
-      ),
-      null);
     $page->setSearchDefaultScope(PhabricatorSearchScope::SCOPE_COMMITS);
 
     $page->appendChild($view);