refactor: remove profiler4fun#64
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Removes the experimental profiler_4fun input and all associated code paths, simplifying the action to always use the standard profiler output. Also normalizes action.yaml string quoting to double-quotes.
Changes:
- Drops
profiler_4funinput fromaction.yamland the related state/env wiring insrc/main.js,src/action.js, andsrc/post.js. - Simplifies
resolveSelectedProfilerFile()insrc/post.jsto a single, fixed lookup chain for the standard profiler file. - Rebuilds bundled
dist/main/index.jsanddist/post/index.js(including unrelated upstream dependency updates pulled in by the rebuild).
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
action.yaml |
Removes profiler_4fun input and reformats string quoting. |
src/main.js |
Drops profiler4fun state/env saving. |
src/action.js |
Removes JIBRIL_PROFILER4FUN_FILE from generated Jibril env file. |
src/post.js |
Removes selected-profiler resolution; always uses standard profiler file. |
dist/main/index.js |
Regenerated bundle reflecting source changes plus dependency updates. |
dist/post/index.js |
Regenerated bundle reflecting source changes plus dependency updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
profiler_4funinput option, and remove all references to such functionality from the action.