Allow absolute paths for snapshot directories #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for the PR. could you add this... https://github.com/ktsn/backstop-compare-test to the examples directory. Maybe name it absolute-paths. |
Author
|
@garris Added it into the |
Owner
|
Thank you for posting this. I am planning to promote the current canary to @latest this week. I will merge this into canary after promoting the current so we can test it out. I am just a little concerned this could break existing implementations so I want others to test it for a while. Cheers. |
garris
approved these changes
Jun 28, 2017
Owner
garris
left a comment
garris
left a comment
There was a problem hiding this comment.
Looks good. Thanks for you patience!
Owner
|
The files have changed significantly so I will merge this by hand. I will close the ticket when complete. |
garris
added a commit
that referenced
this pull request
Jun 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thank you for the great tool! I'm using it in some projects and it is really helpful!
I'm making this PR because I realized BackstopJS does not handle absolute paths in
paths.bitmaps_referenceandpaths.bitmaps_text. This is not a problem in ordinary projects but I'm facing the case that needs to use absolute paths in it. This PR allows us to set absolute paths in the config.You can confirm the current behavior by the following reproduction.
https://github.com/ktsn/backstop-compare-test
By the way, I'm not sure how we should write test code for such the fix. If it is needed, please let me know.
Thanks!