v1.26.1.0 fix: gbrain-sync orchestrator resolves sibling via import.meta.dir#1312
Merged
v1.26.1.0 fix: gbrain-sync orchestrator resolves sibling via import.meta.dir#1312
Conversation
…meta.dir Codex M9: runBrainSyncPush hardcoded ~/.claude/skills/gstack/bin/gstack-brain-sync, so any host that wasn't Claude Code (Codex CLI, dev workspace) hit the existsSync guard and silently skipped curated-artifact push. Replace with the sibling-resolution pattern already in runMemoryIngest at line 193. Regression test asserts the orchestrator no longer takes the lying-skip path when HOME has no ~/.claude/skills/gstack tree.
The 33 KB preamble byte budget hadn't been bumped through v1.25.1.0 (AskUserQuestion recommendation pattern) and v1.26.0.0 (gbrain sync block). plan-ceo-review SKILL.md sat at 33,018 bytes — 18 over the ratchet. Comment in the test already authorizes this kind of intentional-growth bump. Lifted to 34 KB which gives ~700 B of headroom for the next preamble change. claude-ship-SKILL.md and factory-ship-SKILL.md golden fixtures regenerated against the live /ship template — v1.25.1.0 added the canonical "Recommendation: <action> because ..." line to the adversarial subagent prompts but the goldens were never re-baked.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
E2E Evals: ✅ PASS0/0 tests passed | $0 total cost | 12 parallel runners
12x ubicloud-standard-2 (Docker: pre-baked toolchain + deps) | wall clock ≈ slowest suite |
gonnabe88
pushed a commit
to gonnabe88/gstack
that referenced
this pull request
May 9, 2026
…eta.dir (garrytan#1312) * fix: gbrain-sync orchestrator resolves brain-sync sibling via import.meta.dir Codex M9: runBrainSyncPush hardcoded ~/.claude/skills/gstack/bin/gstack-brain-sync, so any host that wasn't Claude Code (Codex CLI, dev workspace) hit the existsSync guard and silently skipped curated-artifact push. Replace with the sibling-resolution pattern already in runMemoryIngest at line 193. Regression test asserts the orchestrator no longer takes the lying-skip path when HOME has no ~/.claude/skills/gstack tree. * chore: bump plan-review preamble ratchet + regenerate ship goldens The 33 KB preamble byte budget hadn't been bumped through v1.25.1.0 (AskUserQuestion recommendation pattern) and v1.26.0.0 (gbrain sync block). plan-ceo-review SKILL.md sat at 33,018 bytes — 18 over the ratchet. Comment in the test already authorizes this kind of intentional-growth bump. Lifted to 34 KB which gives ~700 B of headroom for the next preamble change. claude-ship-SKILL.md and factory-ship-SKILL.md golden fixtures regenerated against the live /ship template — v1.25.1.0 added the canonical "Recommendation: <action> because ..." line to the adversarial subagent prompts but the goldens were never re-baked. * chore: bump version and changelog (v1.26.1.0) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Source fix (1 line):
bin/gstack-gbrain-sync.ts:222—runBrainSyncPushnow resolves its siblinggstack-brain-syncbinary viajoin(import.meta.dir, "gstack-brain-sync")instead of a hardcoded~/.claude/skills/gstack/bin/...path. This matches the pattern already inrunMemoryIngestat line 193.The orchestrator's curated-git-push stage now fires from any host install — Claude Code, Codex CLI, dev workspace — instead of silently no-op'ing with
"skipped (gstack-brain-sync not installed)"outside the Claude Code install root. Closes Codex outside-voice finding M9.Maintenance bundled in:
plan-reviewpreamble byte budget bumped 33 KB → 34 KB. v1.25.1.0 (recommendation pattern) + v1.26.0.0 (gbrain sync block) added intentional preamble bytes; the ratchet just hadn't been bumped to track. Comment in the test already authorizes this kind of intentional-growth bump.claude-ship-SKILL.mdandfactory-ship-SKILL.mdregenerated against the live/shiptemplate. v1.25.1.0 added the canonicalRecommendation: <action> because ...line to the adversarial subagent prompts; the goldens hadn't been re-baked.Commits
Test Coverage
New regression test in
test/gstack-gbrain-sync.test.tsruns the orchestrator with a syntheticHOME(no~/.claude/skills/gstacktree), then asserts the lying-skip path is no longer taken. Pre-fix:"skipped (gstack-brain-sync not installed)". Post-fix: real spawn output (or honest spawn-error code), never the misleading skip message.The existing
runMemoryIngestprecedent has no path-resolution test; this PR establishes the pattern. Out-of-scope to retroactively coverrunMemoryIngesthere.Tests: 456 → 457 (+1 new). 0 fails.
End-to-end smoke from this Conductor workspace:
Pre-Landing Review
Diff scope: 24 source-impacting lines + 5 lines of fixture regen. No SQL, no LLM trust boundary, no conditional side effects, no auth surface. Claude adversarial subagent skipped for proportionality — the Codex M9 finding IS the outside voice on record for the source change, and the maintenance work (ratchet + goldens) is mechanical sync to existing template state.
Plan Review
/plan-eng-reviewran on this branch and returned CLEAR with 1 test gap resolved (the regression test above). See plan file for full review report.Test plan
bun test test/gstack-gbrain-sync.test.ts— 9 pass (8 existing + 1 new regression)bun test test/gen-skill-docs.test.ts— 374 pass, including theOption A budgettest that was red onorigin/mainbun test test/host-config.test.ts— 73 pass, including all three ship-skill golden-file regressions~/.claude/skills/gstack/workspace returnssummary: "curated artifacts pushed"instead of the misleading skip message🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmithwith what you need.