fix(docs): correct per-skill symlink removal snippet in README uninstall#1338
Open
stedfn wants to merge 1 commit intogarrytan:mainfrom
Open
fix(docs): correct per-skill symlink removal snippet in README uninstall#1338stedfn wants to merge 1 commit intogarrytan:mainfrom
stedfn wants to merge 1 commit intogarrytan:mainfrom
Conversation
Closes garrytan#1130. The manual-uninstall fallback in `## Uninstall` → `### Option 2` used `find ~/.claude/skills -maxdepth 1 -type l`, which finds nothing on real installs. Each `~/.claude/skills/<name>/` is a real directory, and only `<name>/SKILL.md` inside it is a symlink into `gstack/`. The find never matched, so the snippet silently removed nothing. Replace with a directory walk that inspects each `<name>/SKILL.md`: find ~/.claude/skills -mindepth 1 -maxdepth 1 -type d ! -name gstack → check $dir/SKILL.md is a symlink → readlink it → if target is gstack/* or */gstack/*: rm -f the link, rmdir the dir (only if empty — preserves any user-added files) Excludes the top-level `gstack/` dir from the walk; that's removed by step 3 of the same uninstall block. `bin/gstack-uninstall` (the script-mode path) already handles the layout correctly via its own walk; only this manual fallback needed updating. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Merged
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1130.
Problem
The manual-uninstall fallback in
## Uninstall→### Option 2uses:This finds nothing on real installs. Each
~/.claude/skills/<name>/is a real directory, and only<name>/SKILL.mdinside it is a symlink intogstack/(perbin/gstack-relink). The find walks one level for symlinks at that depth — there are none — and silently removes nothing.Fix
Replace with a directory walk that inspects each
<name>/SKILL.md:gstack/dir from the walk; step 3 of the same block removes it.rm -f+rmdir(vsrm -rf) so any user-added files in a per-skill dir are preserved.bin/gstack-uninstall(script mode) already handles the layout correctly via its own walk; only this manual fallback needed updating.Verification
bash -nparse-checks clean.git diff upstream/main -- README.mdshows only the snippet replaced (+12/-3, scoped to the lines under# 2. Remove per-skill symlinks pointing into gstack/).