fix: avoid CLAUDE_SKILL_DIR in hook frontmatter#1872
Closed
maxpetrusenkoagent wants to merge 1 commit into
Closed
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Author
Author
|
Addressed Codex reviewer blocker. Fix:
Verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1871 by removing
CLAUDE_SKILL_DIRfrom Claude skill-frontmatterPreToolUsehook commands. Claude Code 2.1.162 does not populate that variable for frontmatter hooks, so the generated hook command can expand to an invalid/../...path before the safety check runs.The affected hook skills now use the installed Claude gstack skill root path directly:
carefulfreezeguardinvestigateTemplate and generated
SKILL.mdfiles are updated together.Tests
ulimit -n 4096; bun test test/gen-skill-docs.test.tsNotes
This was produced through the Hermes OSS PR lane after the first OpenClaw automation run failed to emit a PR URL. The lane now uses a persistent manager-owned worktree so useful diffs survive agent compaction/session exits.
Fixes #1871