RFC #289: land phase-1 host integration contract#364
Open
loocor wants to merge 11 commits intogarrytan:mainfrom
Open
RFC #289: land phase-1 host integration contract#364loocor wants to merge 11 commits intogarrytan:mainfrom
loocor wants to merge 11 commits intogarrytan:mainfrom
Conversation
Make `~/.gstack` the canonical runtime home and keep host directories as thin discoverability layers. Unify host layout rules across generation, setup, packaging, and health checks so install behavior can be validated and published consistently. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Document the new `~/.gstack` canonical runtime model and capture the current branch checkpoint plus scoped follow-up work in the host integration RFC. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Keep the shared runtime canonical without breaking local dev flows. Only trust the workspace browse binary when it validates against shared runtime version metadata. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Keep the shared runtime canonical while preserving workspace browse binaries for validated local development. Align the host contract and regression tests with the workspace-validated policy. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Make /gstack-upgrade match the ~/.gstack primary-runtime model. Fix rollback messaging, refresh workspace sidecars explicitly, and cover the new flow in E2E support code. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Capture the post-checkpoint runtime model in the RFC and user-facing upgrade docs so reviewers can see what shipped versus what was deliberately deferred. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Pulls the branch onto the latest upstream baseline before the next host-adapter steps, so OpenCode and later hosts build on current main behavior instead of a stale install/runtime surface. Keeps the shared-runtime host contract intact while absorbing upstream skills, repo-mode helpers, and coverage-audit prompt generation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codex and Gemini still declared repo-root `.agents/skills` workspace discovery even though setup materializes workspace fallbacks under `.gstack`. Align the host registry, generated setup guidance, upgrade copy, and regression coverage so the install/runtime contract matches the shared-runtime model before this tranche closes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Keep setup, generated skills, and validation aligned around the new shared runtime layout. This avoids clean checkout failures and makes Codex and Gemini discovery depend on an explicit install contract. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Handle chunked HTTP bodies in the raw loopback client so health checks and command output are parsed correctly after the proxy-avoidance change. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Pull in upstream plan review placeholder updates while preserving the shared runtime contract and generator behavior on this branch. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Author
|
Reviewer guide — if you want the shortest path through this PR, I’d focus on these in order:
The biggest thing I’d love feedback on is whether this PR now makes the host/runtime boundary explicit enough that a second host can plug into it later without us falling back into more one-off install/discovery exceptions. |
This was referenced Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
RFC: define a standard host integration contract for gstack)What This PR Lands
scripts/host-registry.tsas the single source of truth for host layouts, discovery roots, runtime roots, path rewrites, and generated output locations~/.gstackthe canonical shared runtime home, with host-specific roots becoming thin discoverability layers and repo-local.gstackacting as the workspace sidecar/fallbacksetup,scripts/gen-skill-docs.ts,scripts/skill-check.ts, packaging, and regression tests to the shared contractCODEX_PLAN_REVIEWplaceholder support merged from upstreamWhy The Diff Is Large
SKILL.mdoutput and contract-driven rewrites flowing from the registry / shared-runtime changescripts/host-registry.ts,scripts/gen-skill-docs.ts,setup,scripts/skill-check.ts,browse/src/cli.ts, and the related testsRoadmap Progress
Intentionally Not In Scope
Test Plan
bun test test/gen-skill-docs.test.tsbun run skill:checkgit diff --checkRefs #289
🤖 Generated with Claude Code