fix: make generated commit trailers host-aware#382
Open
wmzhai wants to merge 1 commit intogarrytan:mainfrom
Open
fix: make generated commit trailers host-aware#382wmzhai wants to merge 1 commit intogarrytan:mainfrom
wmzhai wants to merge 1 commit intogarrytan:mainfrom
Conversation
Resolve commit footer generation in gen-skill-docs so generated Codex skills no longer inject a Claude co-author trailer into ship and document-release commit examples. Add regression coverage for the templates and both host outputs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gen-skill-docsCo-Authored-Bytrailers from generated Codex/shipand/document-releasecommit examplesProblem
Generated Codex skill docs for
/shipand/document-releaseincluded a hardcoded ClaudeCo-Authored-Bytrailer in their sample commit messages. That makes Codex-authored commits inherit the wrong AI footer.Fix
COMMIT_COAUTHOR_TRAILER_BLOCKplaceholder to the skill-doc generatorship/SKILL.md.tmplanddocument-release/SKILL.md.tmplto use that placeholder instead of hardcoding a trailerFixes #282.
Verification
bun run gen:skill-docsbun run gen:skill-docs --host codexbun test test/gen-skill-docs.test.tsbun test