fix: force comparison board as default variant chooser (v0.14.1.0)#658
Merged
fix: force comparison board as default variant chooser (v0.14.1.0)#658
Conversation
The comparison board ($D compare --serve) was being skipped in favor of showing variants inline + AskUserQuestion "which do you prefer?" — a degraded experience missing rating controls, comments, and remix buttons. Changes: - Replace "show inline" instruction with "do NOT show inline, proceed to comparison board" in plan-design-review/SKILL.md.tmpl - Add CRITICAL RULE: never use AskUserQuestion as the variant chooser - Change DESIGN_SHOTGUN_LOOP resolver to AskUserQuestion-first wait with polling fallback (affects all 3 consumer skills) - Fix board URL from /design-board.html (404) to / (correct) - Improve serve-failure fallback to show variants inline via Read tool
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
E2E Evals: ✅ PASS9/9 tests passed | $1.34 total cost | 12 parallel runners
12x ubicloud-standard-2 (Docker: pre-baked toolchain + deps) | wall clock ≈ slowest suite |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The design comparison board (
$D compare --serve) was being skipped in favor of showing variants inline + AskUserQuestion "which do you prefer?" — a degraded experience missing rating controls, comments, and remix/regenerate buttons.Comparison board enforcement:
plan-design-review/SKILL.md.tmplAskUserQuestion-first wait mechanism (shared resolver):
DESIGN_SHOTGUN_LOOPinscripts/resolvers/design.tsfrom polling-first to AskUserQuestion-first/plan-design-review,/design-shotgun,/design-consultationCodex adversarial review fixes:
/design-board.html(404) to/(where the server actually serves)Test Coverage
Step 3.4: All new code paths have test coverage. Template text changes tested via
gen-skill-docs.test.tsintegration.Pre-Landing Review
No issues found. Prompt template text and template resolver string only — no SQL, concurrency, or security boundaries.
Adversarial Review
Codex found 4 issues (medium tier, 83 source lines):
/design-board.htmlto/Plan Completion
8/8 plan items DONE — all implementation and verification items addressed.
Test plan
bun testpasses (pre-existing test-2 FAIL unchanged)bun run gen:skill-docsregenerates all SKILL.md files$D compare --servecommands/not/design-board.html🤖 Generated with Claude Code