fix: use $HOME instead of ~ for browse/design binary paths#843
Open
mvanhorn wants to merge 1 commit intogarrytan:mainfrom
Open
fix: use $HOME instead of ~ for browse/design binary paths#843mvanhorn wants to merge 1 commit intogarrytan:mainfrom
mvanhorn wants to merge 1 commit intogarrytan:mainfrom
Conversation
Claude Code's bash safety heuristic fires a permission prompt on every browse/design command because tilde in variable assignments triggers "Tilde in assignment value" warnings. Change browseDir and designDir in buildHostPaths() to use $HOME instead of ~. Keep skillRoot and binDir with tilde since they appear in command substitution and prose contexts that don't trigger the heuristic. Fixes garrytan#785
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
browseDiranddesignDirinbuildHostPaths()(scripts/resolvers/types.ts:40-41) to use$HOMEinstead of~. Regenerates all 16 affected SKILL.md files.Problem
Claude Code's bash safety heuristic fires a permission prompt on every browse/design command:
This triggers on the generated pattern
B=~/.claude/skills/gstack/browse/dist/browsein every SKILL.md that uses the browser. Frequent interruptions during/browse,/qa,/design-review, and 14 other skills.Changes
One source change in
scripts/resolvers/types.ts:skillRootandbinDirstay with~because they appear in command substitution and prose contexts that don't trigger the heuristic.Testing
337/338 gen-skill-docs tests pass. The 1 failure is a pre-existing VERSION/package.json mismatch (#399), unrelated to this change. Verified:
B=~/orD=~/patterns remain in generated SKILL.md filesskillRootpaths still use~(test expectations at gen-skill-docs.test.ts:1742/1750 preserved)usesEnvVars: true, unaffected by this path)Fixes #785
This contribution was developed with AI assistance (Codex).