[pull] main from bazel-contrib:main#481
Merged
Merged
Conversation
…ropagated for debugger target (#3483) a94bd0f recently added support for injecting dependencies for easier use of debugger. It allows injecting deps via `--@rules_python//python/config_settings:debugger=<target>`. While the runfiles from `<target>` were inherited in the final binary, the `imports` or `venv_site_packages` were missing. Hence making the debugger target unusable for various corner cases (e.g. when it uses `imports = ...` or when it is coming from pip hub and `venv_site_packages` are on). This PR fixes that, and extends the unit test to include this situation. Fixes: #3481 --------- Co-authored-by: Shayan Hoshyari <hoshyari@adobe.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )