Make hooks more generic with generic gRPC methods #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
mostafa
deleted the
register-custom-hooks-when-initializing-components
branch
mostafa
changed the title
mostafa
added a commit
that referenced
this pull request
Jan 29, 2023
…nitializing-components Register custom hooks when initializing components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a new
OnHookin this PR that helps introduce custom hooks that can be registered in different places. The hook is the same, but theHookNameand what's inside theargsdetermine how it should be processed. The plugins should register theonHookhook and decide on the data they receive. This also enables multiple plugins to register to a customonHookand passargsto each other based on their priority. This way theHookNameneedn't match the plugin'sMethod, i.e.OnHook. Actual implementation of this hook will happen over time.Closes #107.