Fix concurrent connection handling #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onnection is alive
Don't swallow errors Add Cap getter function Return ErrPoolExhausted error if the pool is cap'd and the capacity is full NewPool now accepts either an EmptyPoolCapacity (0) or a positive integer to make an uncap'd or cap'd pool
Add new errors messages Log when the pool is exhausted Clarify log messages and add more comments Flush connection to ensure all the data is sent Server shutdown should happen before disconnections to avoid pool panics Fix tests for server.go
Rename Reconnect to TryReconnect to check for pool exhaustion and client disconnection Add IsExhausted method to check if the available client pool is exhausted Fix comments and add more structured logs
mostafa
force-pushed
the
fix-concurrent-connection-handling
branch
from
2af611a to
4cd9138
Compare
This reverts commit ea6e4d9.
This was referenced Dec 21, 2022
mostafa
added a commit
that referenced
this pull request
Jan 29, 2023
…dling Fix concurrent connection handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few issues with connection management.
Update:
This is unstable for now. I'll try to fix it again.