New config parser #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add config structs to dump consolidated config into them for easier access Extract (almost) all the constants in all the packages into config/constants.go Add getter functions for some fields with validations
Add NewLoggerWithBuffer function to use for testing
Align Server struct
Default config values are very important, that's why we should panic.
Use the new config struct for setting up new objects
Load default global and plugin config before loading config files Unmarshal koanf object into structs for easier access Use "default" config for initializing GatewayD objects
mostafa
force-pushed
the
unmarshal-configs-into-structs
branch
from
91fb7c9 to
d99c2cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I moved the
config_parser.gofrom thecmdpackage into its ownconfigpackage. I extracted almost all of the constants from all packages into theconfig/constants.pyand referenced them in packages from there and introduced new types (structs) to unmarshal konaf configs (global and plugin configs) into those structs for easier access. I also added getters for certain fields, which had more complex types.Closes #73.