Merged
Conversation
…rs`) (ethereum-optimism#17778) * remove GetBlobSidecars from L1BlobSource * remove tests * tweak comments * fix test
* fix(op-acceptance-tests): flake-shake; job URL. Make the job URL in our Slack notification point to the artifacts tab of the report job URL. * fix(op-acceptance-tests): flake-shake; add job URL to PR body. * fix(op-acceptance-tests): flake-shake; report owner. * fix(op-acceptance-tests): flake-shake; tweaked defaults.
…ethereum-optimism#17781) * fix(circleci): always run contracts-bedrock-build before docker-build * fix(circleci): include op-deployer in scheduled-docker-publish
* Interfaced CLI Context * No more side-effect initialization * Wire L1 and Server Overrides to Initialization * add permissable side-effects and mark with comments * Address Adrian's Comments
…nce System (ethereum-optimism#17807) * refactor(ai-contracts-test): use CircleCI artifacts for test exclusion - replace log.jsonl with log.json and fetch via CircleCI API - add circleci-api-token context for artifact access - treat blocked status as success when PR exists - remove .env loading for CI-only execution - improve Devin setup logging to single message * fix(ai-eng): handle server errors and user-stopped sessions in devin client - handle 502 Bad Gateway errors as retryable (like 504) - add support for suspend_requested status when user stops session - fix AttributeError when status is None during blocked check - reduce resource_class from xlarge to large * fix(ai-eng): improve devin session monitoring and reduce noise - reduce timeout messages - remove "finished" status handling - clarify blocked status messages - handle expired status separately - reduce resource class from large to medium * fix(ai-eng): add debug logging and fix artifact parsing in test exclusion - add debug prints to trace CircleCI artifact fetching - fix artifact parsing: use selected_files.test_path instead of test_path * refactor(ai-contracts-test): integrate CircleCI API v2 for artifact-based test exclusion - implement CircleCI API v2 to fetch artifacts from previous runs - exclude test files processed in the last 2 weeks - extract helper functions following SRP - add debug logging for artifact fetching process * fix(ai-contracts-test): prevent crash when manually stopping devin sessions * chore(ai-contracts-test): release v1.0.0 with scheduled execution - add bi-weekly monday-thursday scheduled workflow trigger in CircleCI - update default branch from feature to develop for production use - enhance prompt guidance for test organization and source order matching
…eum-optimism#17811) * fix(op-acceptance-tests): flake-shake; artifacts URL. * fix(op-acceptance-tests): flake-shake; test URL. * fix(op-acceptance-tests): flake-shake; close old/stale PRs. * fix(op-acceptance-tests): flake-shake; updated flake-shake gate. * fix(op-acceptance-tests): flake-shake; upload logs. * fix(op-acceptance-tests): flake-shake; convert JSON logs to plaintext. * fix(op-acceptance-tests): flake-shake; use CircleCI static egress IPs. * clean(op-acceptance-tests): flake-shake; removed dummy test.
…thereum-optimism#17799) * do not error if l1 chain config has no BlobScheduleConfig, if it is an optimism config * op-node: allow for L2 chain configs to be passed to NewL1ChainConfig This should fix the problem where L3 nodes cannot start. Closes ethereum-optimism#17798 * typos
…mism#17816) * op-acceptance-tests: Error handle when direct FCU call errored * op-devstack: Track target node when Engine API invoked
…um-optimism#17649) * txmgr: replace UseCellProofs flag with CellProofTime flag Closes ethereum-optimism#17634 * use default CellProofTime in op-e2e/utils.NewTxMgrConfig * fix comparison * unit test the important bit * WIP * Apply suggestions from code review Co-authored-by: Sebastian Stammler <seb@oplabs.co> * Revert "WIP" This reverts commit 1eb8a91. * improve handling of fallback to cover 4 L1 chains * fix test * add debug log * format * add 12s buffer * avoid overflow --------- Co-authored-by: Sebastian Stammler <seb@oplabs.co>
…timism#17800) * op-{sync-tester|devstack} Support multiple EL Sync Runs * op-acceptance-tests: Increase Unsafe payload signaling for window policy * op-sync-tester: Async Set Canonical When EL Sync done * op-devstack: Enable Engine API for SyncTesterEL * op-acceptance-tests: Multiple EL Sync Runs for SyncTesterEL * op-sync-tester: Reorganize Default EL Sync Policy * op-sync-tester: ELSyncPolicy godoc and better initialization * op-sync-tester: WindowSyncPolicy unit tests * op-acceptance-tests: Comment for EL Sync Policy
…em (ethereum-optimism#17820) * docs(ai-eng): document contract test maintenance system - add ai-eng and contracts-test-maintenance READMEs - add comprehensive operational runbook (601 lines) - cross-reference Notion docs (design doc, tech spec) * docs(ai-eng): remove external notion documentation references * docs(ai-eng): improve documentation clarity and add direct links * docs(ai-eng): update graphite status to active
…ism#17824) * op-deployer: add upgrade v4_1_0 command (ethereum-optimism#17790) * update superchain-registry/validation import * op-deployer: fix upgrader.ArtifactsURL and add tests * op-service: add WithForkBlock opt to anvil * op-deployer: add cli level upgrade tests
…ancedByFCU (ethereum-optimism#17833) Run the new test 'TestL2ELP2PCanonicalChainAdvancedByFCU' through FlakeShake.
…hereum-optimism#17850) This should reduce the chance of CircleCI timeouts.
…usions (ethereum-optimism#17840) - hardcode branch to "develop" to avoid CIRCLE_BRANCH env var issues
…mism#17466) Co-authored-by: Sebastian Stammler <seb@oplabs.co> Co-authored-by: Matt Solomon <msolomon@oplabs.co>
* feat: integrate v2 implementations into opcm * fix: skip v2 implementations if not deployed * chore: bump semver version * feat: conditionally set the v2 games based on feature flag * feat: add override for setup to re-deploy opcm with feature flag * test: improve test by deploying with the feature flag and asserting on output * test: add assertion that the deployment configuration on the dgf is correct * chore: improve test name * refactor: add helper function for feature toggled deployment of opcm * fix: bytecode size check failing * chore: run forge fmt * fix: address CI naming and semver bump * fix: rename setup contract name to align with ci checks * chore: comment out added fix * fix: verify opcm * fix: naming convention for test contracts * fix: move the updates for addGameType to the addGameType pr * fix: proposer removed * fix: rename function for clarity in VerifyOPCM script Rename _isV2Implementation to _isV2DisputeGameImplementation for better clarity about what types of contracts this function checks for. * fix: add proper gameArgs for V2 dispute game registration and fix setting output implementation on outupt struct * test: add helper functin for creating game proxies * test: refactor helper functions for test and remove impl from output struct * test: test args correct on created proxy games * chore: remove unused helper for now * fix: remove guard clause from local issue * chore: bump semver * chore: revert changes to ignore v2 implementations * fix: check bitmap and contract name for ref * test: with feature toggle on * chore: forge fmt * Revert "chore: forge fmt" This reverts commit d029fdb. * Revert "test: with feature toggle on" This reverts commit a932eb6. * chore: forge fmt * fix: test compiler restriction fix * Revert "fix: test compiler restriction fix" This reverts commit 50282cf. * fix: compiler bump * fix: typo * test: add test for verify opcm with v2 dispute games deployed * test: add skips for v1 tests if v2 deployed * fix: skip standard validator until its implemented * fix: skip addGameType until its implemented * fix: skip updatePrestate until its implemented * fix: remove diff in natspec * chore: add TODO comments with issue tracking to skips * fix: bump semver * chore: bump semver * Fix silent merge conflicts with develop * Bump semver version * Run semver-lock * Reintroduce OPContractsManager_Version_Test * Cleanup - revert comment change * Remove v2 contracts from DeployOutput * Remove unused imports * Update DeployOPChain tests to run across feature flags (in progress) * Update OPCM tests to work with FeatureFlags options * Merge PermissionedDisputeGame tests, use feature flags * Merge FaultDisputeGame tests, use feature flag in setup * Remove redundant test * Fix test name * Fix anchorRootNotFound test - pass in extra data * Extend deployment test to check more fields * Add guards around new setImplementation call * Add new error to OPCM interface * Run semver-lock * Prefix var with underscore * Remove unused imports * Regenerate snapshots * Pass opcm as an argument to _verifyOpcmContractRef * Reorganize verifyOPCM v2 skip logic * Add TODO to fix acceptance test * Add function documentation for the new opcm param * Cleanup: add test assertion messages * Remove opcm param from runSingle script * Tweak method documentation * Cleanup dead code --------- Co-authored-by: mbaxter <meredith@oplabs.co>
…17925) * add Test_ProgramAction_OperatorFeeFixTransition * fix * undo changes to submodule * respond to review
… fix tests (ethereum-optimism#17744) * remove proxyAdmin inputs from opcm and sv, derive it from the sysCfg, fix tests * run semver lock for sv * remove unused imports * adapt go code, fix go tests * fix UpgradeOPChain test * fix addGameType go test * use semverComp to make interface usage checks flexible * fix failing ci * use better naming for old opcm interfaces and related contracts * fix go tests * try fix op-acceptance tests * finally fix op-acceptance tests? * update block number in justfile and not do u16a upgrade on tests * add upgradeSuperchainConfig pkg and add e2e bootstrap test for it upgrade in v5_0_0 pkg * fix failing upgrade go test, add more upgradeOPChain solidity test * rm old validate fn from sv interface * rm unused import * add unexpectedEncoding revert test and improved assertion to upgradOPChainInput * fix semgrep * fix upgradeSuperchainConfig script * make upgrade test fork a specific block * update addGameType to support the new opcm addGameType interface * fix go lint * fixes * fixes * fixes * fix semver and go lint * fix go test * fix go test * fix go test * fixes * fixes for add game type go test * fixes * remove outdated test * pull and fix
…8066) * ctb: Fix OPCM std validator test setup for v2 DG * fix typo
ethereum-optimism#18027) * op-deployer: Fix error handling in add_game_type CLI parsing. Previously it exited with an error message when there was no error. * op-deployer: Add flags for new implementations options Also provides standard values as defaults.
* opcm: Add CANNON_KONA support for opcm.upgrade * fix sepolia upgrade integration test * run cannon-kona upgrade in integration test * remove debugme * fix stdvalidator.test_init * fix outdated opcm bindings * update semver; snapshots * cleanup setNewGameImplV2 * fix semver; fix natspec * fix op-deployer Migrate input encoding * fix nits * fix semantic merge conflict * fix fmt * update semver * only expect cannon-kona reverts if feature flag set
…zation (ethereum-optimism#18028) * fix(test): add missing event expectation in burn test * refactor(test): remove redundant initiateWithdrawal tests and add nonce assertion * test(contracts): add coverage for version, receive, messageNonce, and burn edge case * refactor(test): reorganize test contracts to match source function order * fix(test): restore removed initiateWithdrawal tests with scenario-specific assertions * refactor(test): remove redundant zero-balance burn test per review * refactor(test): remove unnecessary contract code length assertion per review --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…um-optimism#18087) * refactor(test): remove redundant contract name from constructor test Simplified test_constructor_operatorFeeVault_succeeds to test_constructor_succeeds to match naming convention used in other FeeVault tests (BaseFeeVault, etc.) * test(contracts): add version format validation for OperatorFeeVault Added OperatorFeeVault_Version_Test contract to validate that the version constant returns a valid semver string using SemverComp.parse() * refactor(test): reorganize test contracts to match source declaration order Moved Version_Test before Constructor_Test to match the order in which version (line 21) and constructor (line 25) are declared in OperatorFeeVault.sol --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…hereum-optimism#18024) * op-deployer: Support working with V2 fault dispute game contracts * Deploying implementations supports the fault dispute game configuration options previously used by deploy dispute game * DeployDisputeGame has been updated to work with v1 and v2 contracts * SetDisputeGameImpl works with and without game args * ReadImplementationAddresses loads the V2 dispute game addresses * op-deployer: Don't validate inputs set as game args when v2 is enabled. * op-deployer: Restore absolute prestate check for V1 contracts. * opcm: Read super dispute game implementation addresses. * opcm: Allow clock extension to be zero again * Store permissionedDisputeGame when V2 enabled * opcm: Restore the clockExtension > 0 check
fails against isthmus networks. Discovered when running against jovian betanet.
* opcm: Set cannon_kona init bond during upgrade * address review comments
* dispute-mon: Add metric to track node endpoint errors * dispute-mon: Add node endpoint error count metric * dispute-mon: Add metric for mixed availability of nodes * dispute-mon: Add metric to track mixed safety * dispute-mon: Add metric for disagreeing output roots * Increase log level for mixed availability * Use better check for RollupEndpointErrors * Fix test after merge * Remove useless logging * Remove unnecessary fields from Service struct * Remove unused function and lint fix
…sm#18109) The latest mise (installed by brew) errors if tools don't have a known install source even if they're disabled. While we control the version of mise used in CI, local development depends on an existing mise to bootstrap and there isn't a good way to ensure it is using a specific version.
* remove DeployProxy * fixes
…imism#18129) * fix: bump mips version from 7 to 8 * fix: don't require building binary to use justfile with correct op-deployer version * fix: remove mips version arg
* feat(ci): run upgrade tests with dev flags Updates CI to run upgrade tests with dev flags enabled. Only OP will run with dev flags enabled for now, this should be sufficient and will avoid dramatically increasing CI impact. * fix: correct cannon kona prestate in validator tests
…mism#18078) * Update opcm.migrate to set super-cannonKona * Validate cannonKona prestates during migrate * Update OCPM migrate tests * Cleanup: add helper to construct gameType expectations * Fix game validation test logic * Fix shadowed var warning * Rework op-deployer migrate CLI args for absolute prestate * Read cannonKona prestate in GenerateOPCMMigrateCalldata * Don't create SuperCannonKona game if prestate is zero * Update migration gameType helper * Clean up test logic, perform stricter checks on empty games * Add error messages * Clear game args when game impl removed * Add test with empty cannonKona prestate * Enforce non-empty cannon prestate * Bump contract version * Run just pre-pr * Cleanup and add another test * Fix test documentation * Add new prestate flags to the migrate CLI command * Update script comment with updated sample input * Add check for consistent permissionless weth contracts post-migrate * Bump opcm version again * Run semver-lock
…-optimism#18131) * all: update op-geth to pull in fusaka timestamps * update for scr changes * point go.mod at op-geth rc * address comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.