Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz Migrate Ignition Headers : gz-sim #1646

Merged
merged 32 commits into from
Apr 13, 2023
Merged

ign -> gz Migrate Ignition Headers : gz-sim #1646

merged 32 commits into from
Apr 13, 2023

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon mentioned this pull request Aug 12, 2022
Open
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Aug 12, 2022
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Aug 15, 2022
@methylDragon methylDragon force-pushed the citadel_header_redirects branch 4 times, most recently from 147dd0f to 7f7e0ae Compare August 19, 2022 02:41
@methylDragon methylDragon force-pushed the citadel_header_redirects branch 8 times, most recently from 68ac30f to 3e04cbd Compare August 19, 2022 19:25
@methylDragon methylDragon changed the title ign -> gz Reverse Ignition Headers : gz-sim ign -> gz Migrate Ignition Headers : gz-sim Aug 22, 2022
@methylDragon methylDragon force-pushed the citadel_header_redirects branch 4 times, most recently from 5c7cb37 to 24c64ff Compare August 27, 2022 00:54
@methylDragon
Migrate headers
419d3b0 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Add redirection headers
a6d78fd 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate include statements
6f468b8 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Leave ignition as primary in headers to fix ABI
4a38e81 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@nkoenig nkoenig mentioned this pull request Jan 27, 2023
Merged
8 tasks
@nkoenig
Copy link
Contributor

nkoenig commented Jan 27, 2023

@iche033 , I think I found the solution here: gazebosim/gz-rendering#813

@nkoenig nkoenig mentioned this pull request Feb 3, 2023
Merged
7 tasks
@nkoenig
Copy link
Contributor

nkoenig commented Feb 3, 2023

@osrf-jenkins run tests please

require rendering 3.7
d451801 
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@nkoenig
Copy link
Contributor

nkoenig commented Feb 6, 2023

@osrf-jenkins run tests please

Fix namespaces
c888577 
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@nkoenig
Merge branch 'ign-gazebo3' into citadel_header_redirects
6681101
@nkoenig
Clarify messages
018cd75 
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
@nkoenig
More debugging
7c5a512 
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
@nkoenig
Fix linter
5eedce0 
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
@nkoenig
More testing
c040e8e 
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
@nkoenig
More debug
dc0b63f 
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
@nkoenig
fix build
9b195e6 
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
@nkoenig
More debug
3542420 
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
@nkoenig
linter
053f6d2 
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
@nkoenig
Fix build
17788e6 
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
@nkoenig
Fix build
7fb7916 
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
@nkoenig
More debug
9ec7f64 
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
@nkoenig
More testing
34a64cb 
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
@nkoenig
More tests
de49b1d 
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
@nkoenig
Fix gui.config
34199a5 
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
@nkoenig
Remove debugging
9c4f6dd 
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
@codecov
Copy link

codecov bot commented Apr 13, 2023 •
edited
Loading

Codecov Report

Merging #1646 (3d47cfb) into ign-gazebo3 (940e5f3) will increase coverage by 0.08%.
The diff coverage is 94.11%.

❗ Current head 3d47cfb differs from pull request most recent head 9c4f6dd. Consider uploading reports for the commit 9c4f6dd to get more accurate results

@@               Coverage Diff               @@
##           ign-gazebo3    #1646      +/-   ##
===============================================
+ Coverage        77.96%   78.04%   +0.08%     
===============================================
  Files              255      255              
  Lines            15041    15080      +39     
===============================================
+ Hits             11726    11769      +43     
+ Misses            3315     3311       -4
Impacted Files Coverage Δ
include/gz/sim/detail/ComponentStorageBase.hh 80.00% <ø> (ø)
include/gz/sim/detail/EntityComponentManager.hh 95.20% <ø> (ø)
include/gz/sim/detail/View.hh 100.00% <ø> (ø)
include/gz/sim/gui/GuiEvents.hh 0.00% <0.00%> (ø)
include/gz/sim/gui/GuiSystem.hh 0.00% <0.00%> (ø)
include/gz/sim/gui/TmpIface.hh 0.00% <0.00%> (ø)
include/gz/sim/EventManager.hh 78.26% <78.26%> (ø)
include/gz/sim/components/Serialization.hh 92.85% <92.85%> (ø)
include/gz/sim/components/Factory.hh 96.05% <96.05%> (ø)
include/gz/sim/EntityComponentManager.hh 100.00% <100.00%> (ø)
... and 97 more

... and 138 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nkoenig nkoenig merged commit 2673c01 into ign-gazebo3 Apr 13, 2023
@nkoenig nkoenig deleted the citadel_header_redirects branch April 13, 2023 20:32
@scpeters scpeters mentioned this pull request Apr 21, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkoenig nkoenig nkoenig left review comments

@chapulina chapulina chapulina requested changes

@mjcarroll mjcarroll mjcarroll approved these changes

@iche033 iche033 Awaiting requested review from iche033 iche033 is a code owner

@azeey azeey Awaiting requested review from azeey azeey is a code owner

@jennuine jennuine Awaiting requested review from jennuine jennuine is a code owner

Assignees
No one assigned
Labels
🏰 citadel Ignition Citadel ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@methylDragon @nkoenig @mjcarroll @chapulina