Forward port 6 to 7 #2019
Merged
Forward port 6 to 7 #2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Migrate headers Signed-off-by: methylDragon <methylDragon@gmail.com> * Add redirection headers Signed-off-by: methylDragon <methylDragon@gmail.com> * Migrate include statements Signed-off-by: methylDragon <methylDragon@gmail.com> * Leave ignition as primary in headers to fix ABI Signed-off-by: methylDragon <methylDragon@gmail.com> * Generate MOC files from gz headers Signed-off-by: Louise Poubel <louise@openrobotics.org> * Migrate msgs include usage Signed-off-by: methylDragon <methylDragon@gmail.com> * Add plugin aliases Signed-off-by: methylDragon <methylDragon@gmail.com> * Fix tests and code check Signed-off-by: Nate Koenig <nate@openrobotics.org> * Added fuel.gazebosim.org test dir Signed-off-by: Nate Koenig <nate@openrobotics.org> * Fix SdfGenerator_TEST Signed-off-by: Nate Koenig <nate@openrobotics.org> * require rendering 3.7 Signed-off-by: Nate Koenig <nate@openrobotics.org> * Fix namespaces Signed-off-by: Nate Koenig <nate@openrobotics.org> * Clarify messages Signed-off-by: Nate Koenig <natekoenig@gmail.com> * More debugging Signed-off-by: Nate Koenig <natekoenig@gmail.com> * Fix linter Signed-off-by: Nate Koenig <natekoenig@gmail.com> * More testing Signed-off-by: Nate Koenig <natekoenig@gmail.com> * More debug Signed-off-by: Nate Koenig <natekoenig@gmail.com> * fix build Signed-off-by: Nate Koenig <natekoenig@gmail.com> * More debug Signed-off-by: Nate Koenig <natekoenig@gmail.com> * linter Signed-off-by: Nate Koenig <natekoenig@gmail.com> * Fix build Signed-off-by: Nate Koenig <natekoenig@gmail.com> * Fix build Signed-off-by: Nate Koenig <natekoenig@gmail.com> * More debug Signed-off-by: Nate Koenig <natekoenig@gmail.com> * More testing Signed-off-by: Nate Koenig <natekoenig@gmail.com> * More tests Signed-off-by: Nate Koenig <natekoenig@gmail.com> * Fix gui.config Signed-off-by: Nate Koenig <natekoenig@gmail.com> * Remove debugging Signed-off-by: Nate Koenig <natekoenig@gmail.com> --------- Signed-off-by: methylDragon <methylDragon@gmail.com> Signed-off-by: Louise Poubel <louise@openrobotics.org> Signed-off-by: Nate Koenig <nate@openrobotics.org> Signed-off-by: Nate Koenig <natekoenig@gmail.com> Co-authored-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <natekoenig@gmail.com>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Not all of the needed include paths are exported with the gz-sim target, so including the gz/sim.hh header doesn't work easily. This test fails to build and illustrates the problem. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Needed since the auto-generated header is gz/gazebo.hh Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Fixes macOS build. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
…/ign-gazebo into nkoenig/3-to-6-05022023
3 to 6 05-02-2023
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
Codecov Report
@@ Coverage Diff @@
## gz-sim7 #2019 +/- ##
===========================================
+ Coverage 64.98% 65.01% +0.03%
===========================================
Files 353 353
Lines 28600 28618 +18
===========================================
+ Hits 18585 18606 +21
+ Misses 10015 10012 -3
|
|
@osrf-jenkins retest this please |
|
@osrf-jenkins retest this please |
mjcarroll
approved these changes
Aug 1, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port ign-gazebo6 to gz-sim7
Branch comparison: gz-sim7...ign-gazebo6
I think there might be some files in
include/ignition/gazebothat should be removed.Also, I would like to get #2011 in before this pr.
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)