Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary headers to fix ABI checker #2070

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Aug 3, 2023

🦟 Bug fix

Summary

#2019 added the files
include/ignition/gazebo/ign/gazebo/Export.hh and include/ignition/gazebo/ignition/gazebo/Export.hh which link to <gz/sim/ign/Export.hh>, but that header doesn't exist. This is breaking the ABI checker because it checks every header.

I don't think these headers are needed especially since the ign component is not really public API.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from mjcarroll as a code owner August 3, 2023 16:09
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Aug 3, 2023
@azeey azeey self-assigned this Aug 3, 2023
@azeey azeey added the beta Targeting beta release of upcoming collection label Aug 3, 2023
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #2070 (f1621f6) into gz-sim7 (0aadc81) will decrease coverage by 0.05%.
The diff coverage is n/a.

❗ Current head f1621f6 differs from pull request most recent head c39a255. Consider uploading reports for the commit c39a255 to get more accurate results

@@             Coverage Diff             @@
##           gz-sim7    #2070      +/-   ##
===========================================
- Coverage    65.03%   64.99%   -0.05%     
===========================================
  Files          354      354              
  Lines        28688    28688              
===========================================
- Hits         18657    18645      -12     
- Misses       10031    10043      +12     

see 2 files with indirect coverage changes

@azeey
Copy link
Contributor Author

azeey commented Aug 3, 2023

My guess is, the abi checker is failing to build the stable branch, so it won't pass until we merge this. I'll go ahead and do that and test on another PR.

@azeey azeey merged commit f3c5e23 into gazebosim:gz-sim7 Aug 3, 2023
5 checks passed
@azeey azeey deleted the fix_abi branch August 3, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants