Skip to content

Conversation

@juliovr
Copy link

@juliovr juliovr commented Sep 3, 2024

The text states that a scanline is only HDraw, and after that, comes a HBlank.

The text states that a scanline is only HDraw, and after that, comes a HBlank.
@exelotl
Copy link
Member

exelotl commented Sep 6, 2024

Thanks for the PR!

There are some grammatical fixes needed:

  • "After all the pixels in one line have been drawn"
  • "The combination of these two is called a scanline."

But also, I'm unsure about the change overall.

The original text doesn't state that a scanline is only HDraw, it just says "After a scanline has been drawn [...] there is a pause" which to me implies there's a time during which the scanline is not being drawn. The GBA hardware is still on that scanline, it's just not drawing it anymore.

My understanding is that a scanline is just 'a row of pixels' and that the reader is supposed to infer from context whether it includes the HBlank period or not. In this chapter, a scanline includes both, but in other contexts it might not, so I'm unsure if a formal definition is needed.

I would like to hear others' opinions on this!

@GValiente
Copy link
Member

I agree with @exelotl.

@avivace
Copy link
Member

avivace commented May 6, 2025

I agree as well with @exelotl

@avivace avivace closed this May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants