Skip to content

Audio registers flags #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2019
Merged

Audio registers flags #3

merged 1 commit into from
Mar 4, 2019

Conversation

alvaro-cuesta
Copy link
Contributor

Added some convenience flags for audio registers.

  • Flags for specific registers right below the related register.
  • Flags common to multiple registers in a separate section.
  • Decided to name SO1/SO2 as LEFT/RIGHT in flags (after looking which terminal is which for the Nth time).
  • All are tested, except AUDVOL_VIN_LEFT/RIGHT which I added for completeness (following hardware.inc notes).

@ISSOtm
Copy link
Member

ISSOtm commented Mar 3, 2019

LGTM. Can't review or push, though, but I'd approve if I could.

@tobiasvl tobiasvl requested a review from ISSOtm March 3, 2019 22:08
@tobiasvl
Copy link
Member

tobiasvl commented Mar 3, 2019

Let me try this review thingamajig

ISSOtm
ISSOtm approved these changes Mar 3, 2019
View reviewed changes
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful constants indeed, it's nice to explain the bits themselves as well!

@tobiasvl tobiasvl merged commit 0f382e8 into gbdev:master Mar 4, 2019
@alvaro-cuesta alvaro-cuesta deleted the audio-flags branch May 25, 2020 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@ISSOtm ISSOtm ISSOtm approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alvaro-cuesta @ISSOtm @tobiasvl