Include information about the window's internal line counter #279
Conversation
I'm not exactly sure on where to put this information in, so I just dropped it here, It would be good to describe an example too, maybe also a little diagram explaining it? I can do that if you want me to, but I decided to just keep it like this until I get some more info about PRs on this doc (such as keeping the design language of diagrams consistent).
|
This section is more of a beginner-friendly overview, and not really the right place to get into nitty-gritty details. The other place where weird window behavior is described is the WX/WY registers, so maybe add an info bubble there? |
|
Yep, I just moved it to the bottom of WY's description, but I still feel this is not its place, as it is not directly related with WY anyways. I'm thinking here might be better? |
|
Right, yeah, I think that makes sense. |
|
There you go, I moved it and made it into an info bubble |
|
Done! |
|
Are there test ROMs that check bit 6 and bit 0's effect on the window's "scanline counter"? |
|
You mean bit 5? Matt's dmg-acid2 tests this behavior here however he doesn't really go into detail on why there should be an internal window line counter, that's why I thought this should be documented here. |
|
Fixed |
|
Matt confirmed to me that the window is still activated when LCDC.0 is reset, bit 5 is the one to care about. Got rid of that bit 0 info |
|
Do you have a source for that? I mean something that would be quoted/linked to within the docs, as per #66. |
You may be familiar with this test, which checks the duration of mode 3 with LCDC.5 set and LCDC.0 not set 😉 https://github.com/mattcurrie/mealybug-tearoom-tests/blob/master/src/ppu/win_without_bg.asm |
|
But yes, a specific test for whether the window's internal line counter is actually incremented when it is activated with LCDC.0 not set would be good too. |
|
This would be good enough for the time being, imo. |
avivace
left a comment
avivace
left a comment
There was a problem hiding this comment.
Looks good to me! Great use of the tip box
4 participants
I'm not exactly sure on where to put this information in, so I just dropped it here, It would be good to describe an example too, maybe also a little diagram explaining it? I can do that if you want me to, but I decided to just keep it like this until I get some more info about PRs on this doc (such as keeping the design language of diagrams consistent).