fix: handle GraphQL errors in security_id_to_symbol gracefully #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some securities (e.g., delisted, private, or certain ETFs) fail when the FetchSecurityMarketData GraphQL query returns UNPROCESSABLE_ENTITY. This change wraps the get_security_market_data call in a try/except block to catch WSApiException and gracefully fall back to returning the bracketed security ID instead of crashing.
gboudreau
added a commit
to gboudreau/ws-api-php
that referenced
this pull request
Jan 9, 2026
Owner
|
This is integrated in 0.28.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using
get_account_balances,get_activities, or other methods that internally callsecurity_id_to_symbol, certain securities cause the API to fail (as they are delisted) with:This is noticeable with self-directed RRSP/TFSA accounts, certain ETFs, and some crypto positions.
Solution
Wrap the
get_security_market_datacall in a try/except to catchWSApiExceptionand gracefully fall back to the bracketed security ID.Changes
get_security_market_datacall (+4 lines)market_data['stock']tomarket_data.get('stock')for safer access