Show screenshot block toast only when overlay is active (android)#128
Merged
Conversation
Owner
|
LGTM, merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces an enhancement to the screenshot event handling logic in
ScreenGuardModule.java. The most notable change is the addition of a conditional check to ensure that a toast notification is only shown when the screen guard overlay is active.Screenshot blocking logic improvements:
ScreenGuardOverlayis activated, preventing unnecessary notifications when the overlay is not active. (android/src/main/java/com/screenguard/ScreenGuardModule.java)