-
Notifications
You must be signed in to change notification settings - Fork 3
Re-enable Jax 0.5.x #999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Re-enable Jax 0.5.x #999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated anyio v4.8.0 -> v4.9.0 Updated async-lru v2.0.4 -> v2.0.5 Updated coverage v7.6.12 -> v7.7.0 Updated jax v0.4.30, v0.4.38 -> v0.4.30, v0.5.2 Updated jaxlib v0.4.30, v0.4.38 -> v0.4.30, v0.5.1 Updated orbax-checkpoint v0.6.4, v0.11.5 -> v0.6.4, v0.11.9 Updated pywin32 v309 -> v310
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
7b7aede to
dd3fac5
Compare
Contributor
Performance reviewCommit
|
Contributor
Author
|
Stein thinning errors seem to be fixed by #1000. |
These have been fixed by the changes in #1000.
Contributor
Performance reviewCommit
|
tp832944
previously approved these changes
Mar 24, 2025
Contributor
|
@rg936672 approved subject to merge conflicts. |
Updated jax v0.4.30, v0.4.38 -> v0.4.30, v0.5.3 Updated jaxlib v0.4.30, v0.4.38 -> v0.4.30, v0.5.3 Updated orbax-checkpoint v0.6.4, v0.11.5 -> v0.6.4, v0.11.10 Updated pyparsing v3.2.1 -> v3.2.2 Updated setuptools v77.0.3 -> v78.0.1
Contributor
Performance reviewCommit
|
tp832944
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Description
Re-allowed jax 0.5.x, ran
uv sync --upgrade, and fixed all failing tests.Some errors were just due to precision issues, which I resolved by tweaking the allowed precision difference.
The other two errors have been marked with TODOs; these should be fixed fairly urgently as they seem to be genuine mathematical errors rather than just precision issues.
How Has This Been Tested?
All tests pass.
Does this PR introduce a breaking change?
No.
Checklist before requesting a review