Skip to content

Issue 7136 - Derive AWS domain suffix from region#7221

Merged
patchwork01 merged 22 commits into
developfrom
7136-domain-suffix
May 21, 2026
Merged

Issue 7136 - Derive AWS domain suffix from region#7221
patchwork01 merged 22 commits into
developfrom
7136-domain-suffix

Conversation

@patchwork01
Copy link
Copy Markdown
Collaborator

@patchwork01 patchwork01 commented May 20, 2026

Make sure you have checked all steps below.

Issue

  • My PR fully resolves the following issues. I've referenced an issue in the PR title, for example "Issue 1234 - My
    Feature". Note that before an issue is finished, you can still make a pull request by raising a separate issue
    for your progress.

Tests

  • My PR adds the following tests based on our test strategy OR does not need testing for this extremely good reason:
    • Covered by existing tests

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it, or I have linked to a
    separate issue for that below.
  • If I have added new Java code, I have added Javadoc that explains it following our conventions and style.
  • If I have added or removed any dependencies from the project, I have updated the NOTICES file.

@patchwork01 patchwork01 changed the title Issue 7136 - Derive AWS domain suffix Issue 7136 - Derive AWS domain suffix from region May 20, 2026
@patchwork01 patchwork01 marked this pull request as ready for review May 20, 2026 15:10
@patchwork01 patchwork01 added the needs-reviewer Pull requests that need a reviewer to be assigned label May 20, 2026
@patchwork01
Copy link
Copy Markdown
Collaborator Author

I'm going to put this on hold and wait for confirmation on whether IAM Service Principals need the DNS suffix or should be left as amazonaws.com.

@ca61688 ca61688 self-assigned this May 21, 2026
@patchwork01
Copy link
Copy Markdown
Collaborator Author

Actually, I'll revert the service principal changes and make a separate issue for that.

ca61688
ca61688 previously approved these changes May 21, 2026
@ca61688 ca61688 dismissed their stale review May 21, 2026 08:20

Patchwork has further changes they wish to make

@ca61688 ca61688 removed their assignment May 21, 2026
@patchwork01
Copy link
Copy Markdown
Collaborator Author

I changed my mind, I don't want to change anything. We can leave the service principals with the DNS suffix included unless it turns out they need to change.

@patchwork01 patchwork01 assigned ca61688 and Rob9786 and unassigned ca61688 May 21, 2026
@patchwork01 patchwork01 assigned patchwork01 and unassigned Rob9786 May 21, 2026
@patchwork01 patchwork01 removed the needs-reviewer Pull requests that need a reviewer to be assigned label May 21, 2026
@patchwork01
Copy link
Copy Markdown
Collaborator Author

The service principals actually should stay as amazonaws.com. I'm reverting those.

Copy link
Copy Markdown
Collaborator Author

@patchwork01 patchwork01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just gone through and found the places where the service principal is derived from the DNS suffix.

@patchwork01 patchwork01 removed their assignment May 21, 2026
@patchwork01 patchwork01 merged commit fcc342f into develop May 21, 2026
8 checks passed
@patchwork01 patchwork01 deleted the 7136-domain-suffix branch May 21, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Detect AWS domain suffix automatically

4 participants