Issue 7136 - Derive AWS domain suffix from region#7221
Merged
Conversation
Collaborator
Author
|
I'm going to put this on hold and wait for confirmation on whether IAM Service Principals need the DNS suffix or should be left as amazonaws.com. |
Collaborator
Author
|
Actually, I'll revert the service principal changes and make a separate issue for that. |
ca61688
previously approved these changes
May 21, 2026
Patchwork has further changes they wish to make
Collaborator
Author
|
I changed my mind, I don't want to change anything. We can leave the service principals with the DNS suffix included unless it turns out they need to change. |
Rob9786
approved these changes
May 21, 2026
Collaborator
Author
|
The service principals actually should stay as amazonaws.com. I'm reverting those. |
patchwork01
commented
May 21, 2026
Collaborator
Author
patchwork01
left a comment
There was a problem hiding this comment.
I've just gone through and found the places where the service principal is derived from the DNS suffix.
This reverts commit f65f0c0.
ab295382
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Issue
Feature". Note that before an issue is finished, you can still make a pull request by raising a separate issue
for your progress.
Tests
Documentation
separate issue for that below.