Fixing possible overflow at sampler and adding unit tests. WIP #1 #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfquaresma
approved these changes
Dec 23, 2017
Member
dfquaresma
left a comment
dfquaresma
left a comment
There was a problem hiding this comment.
Well done! Now there is no dangerous counters at sampler.go, thanks!
To fix #1 completly we still should take care about others dangerous counters as incoming and finished at interceptor.go or gcCount at unavailability.go, but I'm approving that PR anyway. You may want do it in another PR.
Please follow my single comment below. Thanks again!
| next int // Next index in the past slice. | ||
| past []int64 // History of sample size between collections. | ||
| lastFinished int64 // Last number of finished requests. | ||
| curr int64 // Current sample size. |
Member
There was a problem hiding this comment.
I believe that "current sample size" could be misunderstood as "the size of sampler" since newSampler receives a size as parameter, but that's just a detail.
Contributor
Author
There was a problem hiding this comment.
It is important. Good catch! Fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.