Skip to content

Enable use of SI unit abbreviations#187

Merged
gcomte merged 2 commits intomasterfrom
feat/use-si-unit-abbreviations
Jul 24, 2023
Merged

Enable use of SI unit abbreviations#187
gcomte merged 2 commits intomasterfrom
feat/use-si-unit-abbreviations

Conversation

@gcomte
Copy link
Owner

@gcomte gcomte commented Jul 8, 2023

Allow user input 1k to be translated into 1,000 and 1M into 1,000,000 and so on (check out this list)

Fixes #152

@gcomte gcomte force-pushed the feat/use-si-unit-abbreviations branch from 2c620ad to 9f3d810 Compare July 8, 2023 20:45
Copy link
Collaborator

@raweber42 raweber42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe there is a less verbose way to read the amount so that you don't need to read it as a string and strip away the last character, but I don't know what Rust provides for this :)

@gcomte
Copy link
Owner Author

gcomte commented Jul 24, 2023

Looks good. Maybe there is a less verbose way to read the amount so that you don't need to read it as a string and strip away the last character, but I don't know what Rust provides for this :)

Great input but for now I fail to come up with a better scheme.

@gcomte gcomte merged commit a8b5f2f into master Jul 24, 2023
@gcomte gcomte deleted the feat/use-si-unit-abbreviations branch July 24, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use abbreviated numbers in input

2 participants