#288 - Cannot Search Nodes Using Timefield Fixer #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdbrown
reviewed
Dec 14, 2018
CHANGELOG-0.x.md
Outdated
| This changelog references the relevant changes done in 0.x versions. | ||
|
|
||
| ## v0.3.1 | ||
| * (patch) issue #288: cannot search nodes using any time field |
Contributor
There was a problem hiding this comment.
@hunyoboy this is reference an issue from a different repository. just change it to something like * BUG :: Fix invalid string casting on Numbr in ElasticaQueryBuilder.
Contributor
Author
|
@gdbrown Please review at your convenience. Thank you. |
gdbrown
approved these changes
Dec 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug is caused by casting the value to string when it is a number. ElasticSearch expects a type of long and value is reformatted to some exponential format like this "1.5666E.. " This happens during the construction of query for ElasticSearch. Current solution is to ensure that string casting only happens on instance of Numbr class.