Skip to content

#288 - Cannot Search Nodes Using Timefield Fixer #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 14, 2018
Merged

#288 - Cannot Search Nodes Using Timefield Fixer #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5bd51bc
ensure to perform lowercase action for strings data type only
Dec 14, 2018
15e7f1c
bump up change log
Dec 14, 2018
f4a09d0
check to execute string casting if it's only an instance of Numbr
Dec 14, 2018
cd4ca11
update change log comment
Dec 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG-0.x.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
# CHANGELOG for 0.x
This changelog references the relevant changes done in 0.x versions.

## v0.3.1
* BUG :: Fix invalid string casting on Numbr in ElasticaQueryBuilder.

## v0.3.0
__BREAKING CHANGES__
Expand Down
2 changes: 1 addition & 1 deletion src/Builder/ElasticaQueryBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,7 @@ protected function addTermToQuery(string $method, Node $node, ?Field $field = nu
return;
}

$value = $this->lowerCaseTerms ? strtolower((string)$node->getValue()) : $node->getValue();
$value = $this->lowerCaseTerms && !$node instanceof Numbr ? strtolower((string)$node->getValue()) : $node->getValue();
$fieldName = $this->inField() ? $field->getName() : $this->defaultFieldName;

if ($this->inField() && !$this->inSubquery()) {
Expand Down