add default logo and loading previewer logo svg or png #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@BenediktMeierUIT - I think I merged this too quickly. It looks like the change to add internationalization #19, made the fileupload2.js script a module which interferes with being able put your handleImageError method in as an onerror function. I pulled that method out into a separate js and avoided sending the siteUrl variable to it to make things work again in the main branch ( see 3be8983 and 01935a8 ). If you know of a cleaner way to do this, please feel free to add a new PR. |
Closed
Author
|
Okay, I'll take a closer look. I will change something there. Thanks for the reference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same as the previewer page. A default image was also missing.
This first checks whether svg or png exists, if this is not there then a default image is loaded.