Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the package version to 1.9.9 and addresses issues with NA duration values in Day0 detection and GR value calculations. Key changes include replacing direct equality checks with %in% 0 to safely handle NA values and adding explicit checks for missing duration in calculate_GR_value. New test cases have been implemented to ensure NA durations are handled correctly. I have no feedback to provide.
gladkia
approved these changes
Apr 29, 2026
darsoo
approved these changes
Apr 30, 2026
When no t0 rows exist (Duration == NA everywhere), the global all-NA column removal was incorrectly stripping columns from Day0. Save and restore Day0 across the gDRutils::loop call when has_day0 is FALSE, so Day0 is only modified by the t0-specific check (second if).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What changed?
Related JIRA issue: GDR-3366
Replace
== 0with%in% 0for Duration comparisons in Day0 detection, and addis.na(duration)guard in GR value back-calculation.Why was it changed?
Follow-up to gDRimport#119 — Duration can now be
NA_real_and must be handled gracefully throughout the pipeline.Checklist for sustainable code base
Logistic checklist