fix(meep): log z_crop application instead of silently rewriting layers#116
Merged
fix(meep): log z_crop application instead of silently rewriting layers#116
Conversation
When geometry.z_crop is set, _apply_z_crop() rewrites every layer's zmin/zmax/thickness and then clears z_crop. This was previously silent. Emit a single logger.info summarizing the reference layer, crop range, which layers were trimmed, and which were removed entirely. Also document why z_crop is cleared (repeat build_config() calls would otherwise re-crop an already-cropped stack).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
geometry.z_cropis set,_apply_z_crop()silently rewrote every layer'szmin/zmax/thicknessand then clearedz_crop. Users had no way to see which layers were trimmed or removed.logger.infosummarizing the reference layer, crop range, and the trimmed/removed layer names.z_cropis cleared (repeatbuild_config()calls would otherwise re-crop an already-cropped stack).Part of a broader audit for silent config overrides in
gsim.meep/gsim.palace. Follow-ups for higher-severity Palace items (material-type inference, mesh auto-sizing,planar_conductorscarryover) to come.