fix: force utf-8 on write_text so Windows cp1252 doesn't break output#127
Merged
fix: force utf-8 on write_text so Windows cp1252 doesn't break output#127
Conversation
Path.write_text() without an explicit encoding uses the platform's default codec — cp1252 on Windows — and raises UnicodeEncodeError when the payload contains any non-cp1252 character. This is the runtime counterpart to the install-time cp1252 work in #123 and #125: cleaning the source chars fixes today's symptom, but a future edit can reintroduce the bug. Explicit encoding='utf-8' on the three call sites makes the output codec independent of the host locale.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Path.write_text(...)call sites were missingencoding=, defaulting to the host codec — cp1252 on Windows — and raisingUnicodeEncodeErrorwhen the payload contained non-cp1252 chars. This is what causes the runtime failure reported forsim.run()→upload()→write_config().src/gsim/meep/simulation.py:815— generatedrun_meep.pysrc/gsim/meep/models/config.py:415—sim_config.jsonsrc/gsim/common/stack/extractor.py:320— stack YAML (usesallow_unicode=True, so this was the most exposed)