Simplify API for CPW ports (single port with geometry)#33
Merged
nikosavola merged 5 commits intogdsfactory:mainfrom Feb 26, 2026
Merged
Simplify API for CPW ports (single port with geometry)#33nikosavola merged 5 commits intogdsfactory:mainfrom
nikosavola merged 5 commits intogdsfactory:mainfrom
Conversation
Contributor
Author
|
Ouch, I made this PR on top of the local_sim branch. |
nikosavola
reviewed
Feb 25, 2026
Member
nikosavola
left a comment
There was a problem hiding this comment.
I can approve if #13 is merged first or the common commits are dropped with rebase
Contributor
Author
|
Oh, good idea @nikosavola, let me try to rebase |
Contributor
Author
|
There, it should be clean now. |
Contributor
Author
|
Ok, this is passing now |
nikosavola
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In QPDK and possibly other PDKs, the user defines a single port on a CPW line. However, the simulation needs to define two rectangles at the proper positions.
This PR modifies the existing API to match what comes from the user/PDK.
Note that now, the user defines a single "o1" port on the CPW end, and then for the simulation, geometric parameters need to be set.
Future work: those parameters could be extracted from the PDK, if a cross-section is present. We had that in palace-server, and could eventually merge the functionality.
Also note that this PR is needed to support the QPDK #28.