Enhance mesh visualization with solid style and names to all interface surfaces#40
Merged
vvahidd merged 6 commits intogdsfactory:mainfrom Mar 5, 2026
Merged
Conversation
nikosavola
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
style="solid"option toplot_mesh()that renders coloured surfaces per physical group (vs the existing wireframe mode). Includes atransparent_groupsparameter to fade out enclosing volumes like the absorbing boundary.To support this, the mesh pipeline now assigns a physical group to every surface produced by volume fragmentation — named
"vol1__vol2"for shared interfaces (e.g."air__substrate") or"vol__None"for exterior faces. Previously only conductors, ports, and the absorbing boundary had named surfaces.This is good for debugging an existing geometry. For example, we now clearly see that we have both "air" and "airbox" volumes, and a substrate which is larger than the traces -- this might be the root cause of #16. Importantly, this is also blocking the addition of waveports.