improve dependency version constraint and errors #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaypipes
force-pushed
the
jaypipes/depends
branch
2 times, most recently
from
e6ee0a5 to
5118b11
Compare
Overhauls the parsing of the Dependency structs and subfields to actually use semver constraint checks and improve the error messages returned when an invalid dependency struct is specified or a dependency version doesn't meet the specified constraint, as shown in this example: ``` $ gdt run scenario/testdata/depends-not-satisfied-version-constraint.yaml Error: runtime error: dependency not satisfied: "ls" failed version constraint ">99.9.9" ``` Issue gdt-dev/gdt#60 Signed-off-by: Jay Pipes <jaypipes@gmail.com>
jaypipes
force-pushed
the
jaypipes/depends
branch
from
5118b11 to
77946e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overhauls the parsing of the Dependency structs and subfields to actually use semver constraint checks and improve the error messages returned when an invalid dependency struct is specified or a dependency version doesn't meet the specified constraint, as shown in this example:
Issue gdt-dev/gdt#60